Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quick fixes in the scm input #159941

Closed
wants to merge 1 commit into from
Closed

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Sep 2, 2022

Fixes #159940

Screen Shot 2022-09-02 at 11 28 51 AM

@mjbvz mjbvz added this to the September 2022 milestone Sep 2, 2022
@mjbvz mjbvz requested a review from lszomoru September 2, 2022 18:30
@mjbvz mjbvz self-assigned this Sep 2, 2022
@lszomoru
Copy link
Member

lszomoru commented Sep 5, 2022

Thanks @mjbvz! This does fix part of the problem as now the quick fix menu appears but for some reason picking one of the available fixes does nothing - as in the value in the commit input does not get replaced. Not sure if you looked into that but if you do not know from the top of your head what the issue is, I can pick this up and further investigate.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 7, 2022

@lszomoru Yes, I think there are two issues here:

  1. For code actions that use commands, many existing extensions don't know how to work with the scm input. This causes the command to fail

  2. For code actions that use a WorkspaceEdit, it's currently not possible to edit the scm input box. This is because the bulk edit service cannot resolve the text model used by the source control input:

    const promise = this._textModelResolverService.createModelReference(key).then(async ref => {

For point 2, would it make sense to register the scm input model as a normal text model?

@mjbvz mjbvz modified the milestones: September 2022, On Deck Sep 21, 2022
@lszomoru
Copy link
Member

@mjbvz, thanks for these findings. Let me chat with couple of folks and see what would be the best way to move this forward.

@lszomoru lszomoru modified the milestones: On Deck, October 2022 Oct 5, 2022
@lszomoru lszomoru added the scm General SCM compound issues label Oct 5, 2022
@mjbvz mjbvz modified the milestones: October 2022, On Deck Oct 20, 2022
mjbvz added a commit to mjbvz/vscode that referenced this pull request Mar 9, 2023
Fixes microsoft#159940

This is a replacement of microsoft#159941 with proper support for using workspace edits on the scm input box
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 9, 2023

Superseded by #176699

@mjbvz mjbvz closed this Mar 9, 2023
mjbvz added a commit that referenced this pull request Mar 31, 2023
Enable quick fixes in the scm input

Fixes #159940

This is a replacement of #159941 with proper support for using workspace edits on the scm input box
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scm General SCM compound issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable quick fixes in SCM input
2 participants