-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pwsh autocomplete #171648
Pwsh autocomplete #171648
Conversation
@meganrogge this is ready for a review, I'd like to get it in asap so I can start doing smaller incremental changes and track things in issues. Everything is behind a new setting so it should be fairly safe. It's not worth doing a big review of the suggest stuff as it's mostly a fork with parts commented out, which will get cleaned up later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
Part of ##154662
It's a bit rough around the edges currently but it's behind the
terminal.integrated.shellIntegration.suggestEnabled
settingAfter chatting with @jrieken and further thinking, this is the approach I'm taking for the workbench suggest widget:
workbench/services/suggest
will extend theeditor/suggest
where trivial, otherwise things will be forked. This will make the review/abstraction/etc. burden oneditor/suggest
low.If it makes sense to avoid editor components in certain parts of
editor/suggest
later, we could move some to platform. That's not that important from my perspective though.