Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Open Workspace Settings" when User Settings is open (fixes #148709) #225311

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

r3m0t
Copy link
Contributor

@r3m0t r3m0t commented Aug 10, 2024

Fixes #148709

workbench.settings.editor is at the default of ui

Open user settings

Modify a setting

Run command: "open workspace settings"

Before PR: the workspace tab is selected in the settings UI but the settings list still shows the user settings

After PR: the workspace tab is selected and the settings list shows the workspace settings

@rzhao271 rzhao271 added this to the August 2024 milestone Aug 13, 2024
@rzhao271 rzhao271 enabled auto-merge August 13, 2024 23:47
@rzhao271 rzhao271 closed this Aug 13, 2024
auto-merge was automatically disabled August 13, 2024 23:47

Pull request was closed

@rzhao271 rzhao271 reopened this Aug 13, 2024
@rzhao271 rzhao271 enabled auto-merge (squash) August 13, 2024 23:48
@rzhao271 rzhao271 merged commit 1900f9c into microsoft:main Aug 14, 2024
6 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings values are not updated after switching scopes
3 participants