Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize terminal ligatures #237503

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Stabilize terminal ligatures #237503

merged 3 commits into from
Jan 8, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 8, 2025

Fixes #237492
Fixes #235988
Fixes #235316
Fixes #234756
Fixes #234755
Fixes #233006

Summary:

  • Updates xterm.js with a bunch of upstream fixes
  • Exposes terminal.integrated.fontLigatures.fallbackLigatures as a vscode setting
  • Exposes terminal.integrated.fontLigatures.featureSettings as a vscode setting
  • Changes terminal.integrated.fontLigatures -> terminal.integrated.fontLigatures.enabled ⚠️ this is a breaking change but it's preview so it's fine.
  • Remove preview tag
  • Recreate the webgl addon when the ligatures addon is recreated (so font variants/ligatures apply)

Example of this in action, calt ligatures are disabled (-->) and Fira Code's ss03 & variant is in use:

Screenshot 2025-01-08 at 8 36 59 am

@Tyriar Tyriar merged commit 85deb78 into main Jan 8, 2025
7 of 8 checks passed
@Tyriar Tyriar deleted the tyriar/ligatures_stable branch January 8, 2025 17:57
Tyriar added a commit to microsoft/vscode-docs that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment