Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4370: Set default icon for file associations #25497

Merged

Conversation

the-ress
Copy link
Contributor

Added entries to HKCR\Applications to display correct document icon when associating VSCode with unknown file types. (#4370)

@mention-bot
Copy link

@the-ress, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @bpasero to be potential reviewers.

@joaomoreno
Copy link
Member

Oh that's how you do it. Cool, I'll give it a try soon.

@joaomoreno joaomoreno added this to the May 2017 milestone Apr 27, 2017
@joaomoreno joaomoreno self-requested a review May 4, 2017 15:46
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 🍻

@joaomoreno joaomoreno merged commit ba787fb into microsoft:master May 4, 2017
@the-ress the-ress deleted the default-file-association-icon branch May 4, 2017 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants