Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry file of oniguruma when packing #27123

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Add entry file of oniguruma when packing #27123

merged 1 commit into from
Jun 6, 2017

Conversation

WaiSiuKei
Copy link

@WaiSiuKei WaiSiuKei commented May 23, 2017

The entry file of oniguruma (src/oniguruma.js) is cleaned when packing, which may cause a The mode has failed while tokenizing the input error message when running the distribution.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@alexdima
Copy link
Member

alexdima commented Jun 6, 2017

This will be useful once we update to a newer version of oniguruma.

Thank you @WaiSiuKei

@alexdima alexdima merged commit e92fb85 into microsoft:master Jun 6, 2017
@alexdima alexdima added this to the June 2017 milestone Jun 6, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants