Filter settings from no search results link #29261
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user is encouraged to check the exclude settings when there are no search results. Previously this would just open up the settings without any indication which settings are relevant. This change will update the search filter to show `files.exclude` and `search.exclude`.
|
@keegancsmith, |
roblourens
reviewed
Jun 26, 2017
| @@ -164,7 +164,10 @@ export class PreferencesEditor extends BaseEditor { | |||
| this.searchWidget.focus(); | |||
| } | |||
|
|
|||
| public focusSearch(): void { | |||
| public focusSearch(filter?: string): void { | |||
| if (filter !== null) { | |||
There was a problem hiding this comment.
This will pass if filter is undefined, i.e. not passed to focusSearch.
There was a problem hiding this comment.
I'll merge and fix this. Thanks for the PR!
There was a problem hiding this comment.
Thanks! I wrote my first bit of TS code in this PR. I'll check out the fix to learn :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user is encouraged to check the exclude settings when there are no search
results. Previously this would just open up the settings without any indication
which settings are relevant. This change will update the search filter to show
files.excludeandsearch.exclude.