Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "debt - adopt new fs.readdir with stat info" #78929

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Aug 12, 2019

This reverts commit da5fb7d.

@isidorn this restores the code for reading directories as it used to be to fix #78743

@bpasero bpasero added this to the July 2019 Recovery milestone Aug 12, 2019
@bpasero bpasero requested a review from isidorn August 12, 2019 06:25
@bpasero bpasero self-assigned this Aug 12, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 12, 2019

Looks good to me.
Marking as approved since I confirm that it is a revert to the previous behavior.
And the user verified here that it fixes the issue.

@bpasero bpasero merged commit 9a5cd34 into release/1.37 Aug 12, 2019
@bpasero bpasero deleted the ben/fix-78743 branch August 12, 2019 12:44
@rebornix rebornix added the verified Verification succeeded label Aug 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants