Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove terminal link matchers #98182

Merged
merged 11 commits into from
May 20, 2020
Merged

Remove terminal link matchers #98182

merged 11 commits into from
May 20, 2020

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 19, 2020

Part of #96266

@Tyriar Tyriar added this to the May 2020 milestone May 19, 2020
@Tyriar Tyriar self-assigned this May 19, 2020
@Tyriar
Copy link
Member Author

Tyriar commented May 19, 2020

@alexr00 fyi this will pull out the link matcher related code stubs in tasks.

@Tyriar Tyriar closed this May 19, 2020
@Tyriar Tyriar reopened this May 19, 2020
@Tyriar Tyriar mentioned this pull request May 20, 2020
Closed
@alexr00 alexr00 self-requested a review May 20, 2020 08:48
alexr00
alexr00 approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for deleting that tasks code!

@Tyriar Tyriar merged commit 8c54829 into master May 20, 2020
@Tyriar Tyriar deleted the tyriar/96266 branch May 20, 2020 14:24
@Tyriar Tyriar mentioned this pull request May 20, 2020
Closed
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @alexr00