Prevent unnecessary progress indicator refresh

[JSkimming]

Update

The issue has now been fixed with the .NET SDK releases 2.1.701 & 2.2.301, demonstrated by the following builds.

• 2.1.700 - Slow
• 2.1.701 - Fixed
• 2.2.300 - Slow
• 2.2.301 - Fixed

Description

The progress indicator is repeatedly refreshing, even in situations when a log message will not be output, e.g. when the verbosity level is not high enough.

This has resulted in severe performance decorations in some hosted CI systems, where the constant refresh of the stdout is presumably overloading the system.

Related issue

Fixes dotnet/core#2775

[JSkimming]

I'm wondering how I can go about adding some tests. I'm not sure how to test whether the progress indicator is refreshed or not. I've not had a chance to look at the current tests; I just wanted to get the ball rolling with this fix and solicit review before digging into potential tests.

[JSkimming]

I've downloaded the build logs (it wasn't visible from the UI) and it looks like the failed builds were caused by a failure to download packages from MyGet. Can someone with force a rebuild?

2019-05-23T21:04:31.1368261Z   Failed to download package 'Microsoft.VisualStudio.QualityTools.DataCollectors.16.0.0-preview-2148743' from 'https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg'.
2019-05-23T21:04:31.1371366Z   The HTTP request to 'GET https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg' has timed out after 100000ms.
2019-05-23T21:06:11.1621210Z   Failed to download package 'Microsoft.VisualStudio.QualityTools.DataCollectors.16.0.0-preview-2148743' from 'https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg'.
2019-05-23T21:06:11.1622517Z   The HTTP request to 'GET https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg' has timed out after 100000ms.
2019-05-23T21:07:51.1816957Z D:\a\1\s\tools\dotnet\sdk\3.0.100-preview6-012061\NuGet.targets(123,5): error : Failed to download package 'Microsoft.VisualStudio.QualityTools.DataCollectors.16.0.0-preview-2148743' from 'https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg'. [D:\a\1\s\src\package\external\external.csproj]
2019-05-23T21:07:51.1818006Z D:\a\1\s\tools\dotnet\sdk\3.0.100-preview6-012061\NuGet.targets(123,5): error : The HTTP request to 'GET https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/16.0.0-preview-2148743/microsoft.visualstudio.qualitytools.datacollectors.16.0.0-preview-2148743.nupkg' has timed out after 100000ms. [D:\a\1\s\src\package\external\external.csproj]
2019-05-23T21:09:31.1866134Z   Retrying 'FindPackagesByIdAsync' for source 'https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/index.json'.
2019-05-23T21:09:31.1868189Z   The HTTP request to 'GET https://dotnet.myget.org/F/vstest/api/v3/flatcontainer/microsoft.visualstudio.qualitytools.datacollectors/index.json' has timed out after 100000ms.
2019-05-23T21:09:32.5713880Z D:\a\1\s\tools\dotnet\sdk\3.0.100-preview6-012061\NuGet.targets(123,5): error : The feed 'vstest.myget [https://dotnet.myget.org/F/vstest/api/v3/index.json]' lists package 'Microsoft.VisualStudio.QualityTools.DataCollectors.16.0.0-preview-2148743' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [D:\a\1\s\src\package\external\external.csproj]
2019-05-23T21:09:32.5716001Z D:\a\1\s\tools\dotnet\sdk\3.0.100-preview6-012061\NuGet.targets(123,5): error :   Unable to find package 'Microsoft.VisualStudio.QualityTools.DataCollectors.16.0.0-preview-2148743'. [D:\a\1\s\src\package\external\external.csproj]
2019-05-23T21:09:33.3190981Z ... .. .. Restore-Package: Complete.
2019-05-23T21:09:33.4466544Z ##[error]Set-ScriptFailedOnError : Build failed. Stopping as fail fast is set.
At D:\a\1\s\scripts\build.ps1:196 char:5
+     Set-ScriptFailedOnError
+     ~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Set-ScriptFailedOnError

[JSkimming]

@singhsarab can you provide any update on when this is likely to be merged and eventually released?

This has resulted in severe performance decorations in some hosted CI systems, where the constant refresh of the stdout is presumably overloading the system.

I've got several builds that take ages to run, if this is going to take a while I'll downgrade to the earlier version that worked fine.

[emmekappa]

@JSkimming we have had to downgrade our docker image that run the builds/tests to 2.2.204