VsTestConsoleWrapper endsession should shut down vstest console process #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Aug 27, 2019
| this.Setup(); | ||
|
|
||
| this.vstestConsoleWrapper.RunTests(this.GetTestAssemblies(), this.GetDefaultRunSettings(), this.runEventHandler); | ||
| this.vstestConsoleWrapper?.EndSession(); |
There was a problem hiding this comment.
Can vstestConsoleWrapper be null ? :O
singhsarab
reviewed
Aug 27, 2019
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTests.cs
Show resolved
Hide resolved
singhsarab
approved these changes
Aug 27, 2019
singhsarab
reviewed
Aug 27, 2019
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleProcessManager.cs
Show resolved
Hide resolved
singhsarab
reviewed
Aug 27, 2019
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleProcessManager.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2026