Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress assembly architecture, assembly conflict and restore warnings #3323

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 3, 2022

Suppress assembly architecture, assembly conflict and restore warnings that we can't avoid. This is preliminary work to enabling Warnings to be just warnings for local development. And then probably warnings as errors in PR, or ideally warnings as errors in real PRs and warnings as warnings in draft PRs.

@@ -68,6 +68,8 @@
<When Condition="$(TestProject) == 'true'">
<PropertyGroup>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<!-- Suppress warnings about testhost being x64 (AMD64)/x86 when imported into AnyCPU (MSIL) test projects. -->
<NoWarn>$(NoWarn);MSB3270</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both this and the MSBuildWarningsAsMessages in each project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't suppress this warning in each project, just in some. This is blanket suppression for all TestProjects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear. I meant do we need both NoWarn and MSBuildWarningsAsMessages applied (I see that both are "suppressing" the MSB3270).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<NoWarn>$(NoWarn);MSB3270</NoWarn>
<MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);MSB3270</MSBuildWarningsAsMessages>

Do I get it correctly that you want me to do this ^^^ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the other way around depending on which of the 2 property has wider area but yes :)

@nohwnd nohwnd merged commit 909b4f8 into microsoft:main Feb 4, 2022
@nohwnd nohwnd deleted the suppress-testhost-related-warnings branch February 4, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants