-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress assembly architecture, assembly conflict and restore warnings #3323
Suppress assembly architecture, assembly conflict and restore warnings #3323
Conversation
…s that we can't avoid
@@ -68,6 +68,8 @@ | |||
<When Condition="$(TestProject) == 'true'"> | |||
<PropertyGroup> | |||
<GenerateDocumentationFile>false</GenerateDocumentationFile> | |||
<!-- Suppress warnings about testhost being x64 (AMD64)/x86 when imported into AnyCPU (MSIL) test projects. --> | |||
<NoWarn>$(NoWarn);MSB3270</NoWarn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both this and the MSBuildWarningsAsMessages
in each project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't suppress this warning in each project, just in some. This is blanket suppression for all TestProjects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear. I meant do we need both NoWarn
and MSBuildWarningsAsMessages
applied (I see that both are "suppressing" the MSB3270
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<NoWarn>$(NoWarn);MSB3270</NoWarn> | |
<MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);MSB3270</MSBuildWarningsAsMessages> |
Do I get it correctly that you want me to do this ^^^ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or the other way around depending on which of the 2 property has wider area but yes :)
...rm.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj
Outdated
Show resolved
Hide resolved
...ataCollector.UnitTests/Microsoft.TestPlatform.Extensions.BlameDataCollector.UnitTests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <[email protected]>
…om/nohwnd/vstest into suppress-testhost-related-warnings
Suppress assembly architecture, assembly conflict and restore warnings that we can't avoid. This is preliminary work to enabling Warnings to be just warnings for local development. And then probably warnings as errors in PR, or ideally warnings as errors in real PRs and warnings as warnings in draft PRs.