Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImgBot] Optimize images #1871

Merged
merged 2 commits into from
Jan 24, 2022
Merged

[ImgBot] Optimize images #1871

merged 2 commits into from
Jan 24, 2022

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Jan 21, 2022 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

ImgBotApp and others added 2 commits December 16, 2021 06:58
@ImgBotApp
[ImgBot] Optimize images
9251c57 
*Total -- 4,082.74kb -> 1,818.86kb (55.45%)

/doc/windows/package-manager/winget/images/import-command.png -- 543.31kb -> 11.24kb (97.93%)
/doc/windows/package-manager/winget/images/export.png -- 569.79kb -> 13.45kb (97.64%)
/doc/windows/package-manager/winget/images/export-command.png -- 196.41kb -> 4.69kb (97.61%)
/doc/windows/package-manager/winget/images/features.png -- 52.98kb -> 6.87kb (87.04%)
/doc/windows/package-manager/winget/images/uninstall-with-list.png -- 33.63kb -> 5.30kb (84.25%)
/doc/windows/package-manager/winget/images/search.png -- 77.29kb -> 16.41kb (78.77%)
/doc/windows/package-manager/winget/images/uninstall-execute.png -- 18.89kb -> 4.48kb (76.28%)
/doc/windows/package-manager/winget/images/import.png -- 41.90kb -> 10.11kb (75.88%)
/.github/images/WingetInstall.gif -- 220.60kb -> 66.59kb (69.82%)
/doc/windows/package-manager/winget/images/source-list.png -- 12.83kb -> 3.88kb (69.74%)
/doc/windows/package-manager/winget/images/help.png -- 65.24kb -> 20.67kb (68.32%)
/doc/windows/package-manager/winget/images/upgrade.png -- 75.02kb -> 24.33kb (67.57%)
/doc/windows/package-manager/winget/images/uninstall.png -- 62.60kb -> 20.64kb (67.03%)
/doc/windows/package-manager/winget/images/list.png -- 52.51kb -> 17.38kb (66.9%)
/doc/windows/package-manager/winget/images/source.png -- 41.76kb -> 13.98kb (66.51%)
/doc/windows/package-manager/winget/images/list-count.png -- 30.28kb -> 10.41kb (65.63%)
/doc/windows/package-manager/winget/images/install.png -- 24.91kb -> 8.93kb (64.17%)
/doc/windows/package-manager/winget/images/source-list-winget.png -- 15.05kb -> 5.42kb (63.97%)
/doc/windows/package-manager/winget/images/show.png -- 41.56kb -> 15.00kb (63.9%)
/doc/windows/package-manager/winget/images/list-update.png -- 9.92kb -> 3.67kb (63.05%)
/doc/windows/package-manager/winget/images/list-id-source.png -- 7.90kb -> 3.09kb (60.89%)
/doc/windows/package-manager/winget/images/list-name.png -- 9.12kb -> 3.70kb (59.45%)
/doc/windows/package-manager/winget/images/uninstall-multiple.png -- 21.38kb -> 9.00kb (57.88%)
/doc/windows/package-manager/winget/images/hash.png -- 13.23kb -> 5.73kb (56.67%)
/doc/windows/package-manager/winget/images/settings.png -- 23.18kb -> 12.25kb (47.13%)
/src/cpprestsdk/cpprestsdk/Release/samples/BlackJack/BlackJack_UIClient/Assets/SmallLogo.png -- 1.57kb -> 0.84kb (46.51%)
/.github/images/WingetInstallTerminal.gif -- 124.62kb -> 68.61kb (44.95%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/CasaLens141/image/logo.png -- 3.83kb -> 2.39kb (37.68%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/image/logo.png -- 3.83kb -> 2.39kb (37.68%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/SplashScreen.scale-200.png -- 7.52kb -> 4.71kb (37.4%)
/src/AppInstallerCLIPackage/Images/SplashScreen.scale-200.png -- 7.52kb -> 4.71kb (37.4%)
/src/PackagedTests/Assets/SplashScreen.scale-200.png -- 7.52kb -> 4.71kb (37.4%)
/src/AppInstallerTestMsixInstaller/Images/SplashScreen.scale-200.png -- 7.52kb -> 4.71kb (37.4%)
/src/cpprestsdk/cpprestsdk/Release/samples/BlackJack/BlackJack_UIClient/Assets/Logo.png -- 14.19kb -> 9.00kb (36.56%)
/src/Valijson/valijson/thirdparty/urdl-2013-08-15/doc/urdl.png -- 2.82kb -> 1.80kb (36.29%)
/src/cpprestsdk/cpprestsdk/Release/samples/BlackJack/BlackJack_UIClient/Assets/SplashScreen.png -- 16.73kb -> 11.47kb (31.43%)
/.github/images/WIPowerToys.gif -- 301.41kb -> 218.33kb (27.56%)
/src/cpprestsdk/cpprestsdk/Release/samples/BlackJack/BlackJack_UIClient/Assets/StoreLogo.png -- 2.61kb -> 2.03kb (22.16%)
/doc/windows/package-manager/winget/images/upgrade.gif -- 264.45kb -> 213.58kb (19.24%)
/src/AppInstallerTestMsixInstaller/Images/Wide310x150Logo.scale-200.png -- 3.13kb -> 2.61kb (16.67%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/Wide310x150Logo.scale-200.png -- 3.13kb -> 2.61kb (16.67%)
/src/PackagedTests/Assets/Wide310x150Logo.scale-200.png -- 3.13kb -> 2.61kb (16.67%)
/src/AppInstallerCLIPackage/Images/Wide310x150Logo.scale-200.png -- 3.13kb -> 2.61kb (16.67%)
/src/cpprestsdk/cpprestsdk/Release/samples/OAuth2Live/Assets/SplashScreen.png -- 2.10kb -> 1.77kb (15.52%)
/src/cpprestsdk/cpprestsdk/Release/samples/FacebookDemo/Assets/SplashScreen.png -- 2.10kb -> 1.77kb (15.52%)
/src/cpprestsdk/cpprestsdk/Release/samples/WindowsLiveAuth/Assets/SplashScreen.png -- 2.10kb -> 1.77kb (15.52%)
/src/AppInstallerTestMsixInstaller/Images/Square44x44Logo.scale-200.png -- 1.61kb -> 1.38kb (14.51%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/Square44x44Logo.scale-200.png -- 1.61kb -> 1.38kb (14.51%)
/src/AppInstallerCLIPackage/Images/Square44x44Logo.scale-200.png -- 1.61kb -> 1.38kb (14.51%)
/src/PackagedTests/Assets/Square44x44Logo.scale-200.png -- 1.61kb -> 1.38kb (14.51%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/LockScreenLogo.scale-200.png -- 1.40kb -> 1.22kb (12.73%)
/src/PackagedTests/Assets/LockScreenLogo.scale-200.png -- 1.40kb -> 1.22kb (12.73%)
/src/AppInstallerTestMsixInstaller/Images/LockScreenLogo.scale-200.png -- 1.40kb -> 1.22kb (12.73%)
/src/AppInstallerCLIPackage/Images/LockScreenLogo.scale-200.png -- 1.40kb -> 1.22kb (12.73%)
/src/AppInstallerTestMsixInstaller/Images/StoreLogo.png -- 1.42kb -> 1.25kb (12.13%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/StoreLogo.png -- 1.42kb -> 1.25kb (12.13%)
/src/PackagedTests/Assets/StoreLogo.png -- 1.42kb -> 1.25kb (12.13%)
/src/AppInstallerCLIPackage/Images/StoreLogo.png -- 1.42kb -> 1.25kb (12.13%)
/src/AppInstallerCLIE2ETests/TestData/Package/Assets/contrast-white/AppPackageStoreLogo.scale-400_contrast-white.png -- 1.31kb -> 1.15kb (11.67%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/image/bing-logo.jpg -- 6.12kb -> 5.48kb (10.34%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/CasaLens141/image/bing-logo.jpg -- 6.12kb -> 5.48kb (10.34%)
/src/AppInstallerTestMsixInstaller/Images/Square150x150Logo.scale-200.png -- 2.87kb -> 2.58kb (9.94%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/Square150x150Logo.scale-200.png -- 2.87kb -> 2.58kb (9.94%)
/src/AppInstallerCLIPackage/Images/Square150x150Logo.scale-200.png -- 2.87kb -> 2.58kb (9.94%)
/src/PackagedTests/Assets/Square150x150Logo.scale-200.png -- 2.87kb -> 2.58kb (9.94%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/CasaLens141/image/wall.jpg -- 482.16kb -> 435.91kb (9.59%)
/src/cpprestsdk/cpprestsdk/Release/samples/CasaLens/image/wall.jpg -- 482.16kb -> 435.91kb (9.59%)
/doc/windows/package-manager/package/images/pull-request.png -- 18.39kb -> 16.64kb (9.51%)
/src/AppInstallerCLIE2ETests/TestData/Package/Assets/contrast-white/AppPackageStoreLogo.scale-150_contrast-white.png -- 0.63kb -> 0.58kb (7.76%)
/src/AppInstallerCLIE2ETests/TestData/Package/Assets/contrast-white/AppPackageStoreLogo.scale-125_contrast-white.png -- 0.60kb -> 0.55kb (7.35%)
/src/AppInstallerTestMsixInstaller/Images/Square44x44Logo.targetsize-24_altform-unplated.png -- 1.23kb -> 1.14kb (6.85%)
/tools/SampleWinGetUWPCaller/AppInstallerCaller/Assets/Square44x44Logo.targetsize-24_altform-unplated.png -- 1.23kb -> 1.14kb (6.85%)
/src/PackagedTests/Assets/Square44x44Logo.targetsize-24_altform-unplated.png -- 1.23kb -> 1.14kb (6.85%)
/src/AppInstallerCLIPackage/Images/Square44x44Logo.targetsize-24_altform-unplated.png -- 1.23kb -> 1.14kb (6.85%)
/doc/windows/package-manager/package/images/fork.png -- 3.75kb -> 3.50kb (6.61%)
/src/AppInstallerCLIE2ETests/TestData/Package/Assets/contrast-white/AppPackageStoreLogo.scale-100_contrast-white.png -- 0.52kb -> 0.50kb (3.91%)
/src/AppInstallerCLIE2ETests/TestData/Package/Assets/contrast-white/AppPackageStoreLogo.scale-200_contrast-white.png -- 0.70kb -> 0.68kb (2.66%)

Signed-off-by: ImgBotApp <[email protected]>
@vedantmgoyal9
Merge pull request #1 from vedantmgoyal2009/imgbot
f65c7fc 
[ImgBot] Optimize images
@vedantmgoyal9 vedantmgoyal9 requested a review from a team as a code owner January 21, 2022 21:40
@JohnMcPMS
Copy link
Member

Seems fine to me, but I will let @denelon take a look to make sure that the actual images we care about are good.

The images in the subtrees might get stomped in the future, but I don't think we need any of them anyway (could get 100% size reduction by just deleting them really).

@denelon
Copy link
Contributor

denelon commented Jan 24, 2022

I'm fine with the space saved here. I don't know if there is a decent way to determine if any of these can safely be deleted or not.

@JohnMcPMS
Copy link
Member

I think the only and best way would be to simply delete them in a PR and see.

@JohnMcPMS JohnMcPMS merged commit 4bead76 into microsoft:master Jan 24, 2022
@vedantmgoyal9 vedantmgoyal9 mentioned this pull request Apr 12, 2022
Merged
2 tasks
@jedieaston jedieaston mentioned this pull request Jul 22, 2022
Closed
2 tasks
This was referenced Aug 20, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedantmgoyal9 @JohnMcPMS @denelon @ImgBotApp