Updating readme to include instructions to opt out of telemetry. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denelon
reviewed
May 21, 2020
README.md
Outdated
| This project collects usage data and sends it to Microsoft to help improve our products and services. Note however that no data collection is performed when using your private builds. | ||
| The winget.exe client is instrumented to collect usage and diagnostic (error) data and sends it to Microsoft to help improve the product. | ||
|
|
||
| Note however that if you build the client yourself the instrumentation will not be enabled and no data will be send to Microsoft. |
There was a problem hiding this comment.
I think this sentence is a bit more clear if the first three words are removed. #Resolved
yao-msft
reviewed
May 21, 2020
README.md
Outdated
| This project collects usage data and sends it to Microsoft to help improve our products and services. Note however that no data collection is performed when using your private builds. | ||
| The winget.exe client is instrumented to collect usage and diagnostic (error) data and sends it to Microsoft to help improve the product. | ||
|
|
||
| Note however that if you build the client yourself the instrumentation will not be enabled and no data will be send to Microsoft. |
There was a problem hiding this comment.
send [](start = 111, length = 4)
sent? #Resolved
yao-msft
reviewed
May 21, 2020
README.md
Outdated
|
|
||
| WinGet client respects machine wide privacy settings and users can opt-out on their device, as documented in the Microsoft Windows privacy statement [here] (https://support.microsoft.com/en-us/help/4468236/diagnostics-feedback-and-privacy-in-windows-10-microsoft-privacy). | ||
|
|
||
| In short to opt-out, Go to Start , then select Settings > Privacy > Diagnostics & feedback and select Basic. |
There was a problem hiding this comment.
[](start = 32, length = 1)
nit: extra space #Resolved
yao-msft
reviewed
May 21, 2020
README.md
Outdated
|
|
||
| WinGet client respects machine wide privacy settings and users can opt-out on their device, as documented in the Microsoft Windows privacy statement [here] (https://support.microsoft.com/en-us/help/4468236/diagnostics-feedback-and-privacy-in-windows-10-microsoft-privacy). | ||
|
|
||
| In short to opt-out, Go to Start , then select Settings > Privacy > Diagnostics & feedback and select Basic. |
There was a problem hiding this comment.
[](start = 56, length = 1)
extra space #Resolved
denelon
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow