Add CsWinRT projection producing project for deployment API #4949

JohnMcPMS · 2024-11-07T20:11:52Z

Change

Produce a CsWinRT projection for Microsoft.Management.Deployment.
Move to CsWinRT 2.1.6 across the solution.

Microsoft Reviewers: Open in CodeFlow

florelis · 2024-11-07T21:28:11Z

src/AppInstallerCLI.sln

 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|ARM64.ActiveCfg = Release|Any CPU
 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|ARM64.Build.0 = Release|Any CPU
 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|x64.ActiveCfg = Release|Any CPU
 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|x64.Build.0 = Release|Any CPU
 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|x86.ActiveCfg = Release|Any CPU
 		{1F56BECB-D65D-4BBA-8788-6671B251392A}.Release|x86.Build.0 = Release|Any CPU
+		{1F56BECB-D65D-4BBA-8788-6671B251392A}.ReleaseStatic|ARM64.ActiveCfg = Release|Any CPU


Not from this change but shouldn't this be also ReleaseStatic? Looks like it is for Microsoft.WinGet.Client.Engine, which isn't actually built for ARM64, but the inconsistency just jumped out at me...

Sergio0694

Nice!! Left a few notes 🙂

Sergio0694 · 2024-11-08T00:30:54Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+    Forcing this version to continue using an older CsWinRT release while issues are resolved.
+    !!! Remove this on the next Microsoft.Windows.CsWinRT package version update. !!!
+    -->
+    <WindowsSdkPackageVersion>10.0.22000.34</WindowsSdkPackageVersion>


This should be .53 for .NET 8, and .52 for .NET 6

Good reminder that there is a different number for 6 vs 8. But we had to use an older one due to a bug; I can see if that bug has been fixed since.

We can't use .34 anyway because it's not AOT compatible 😅
I suspect whatever that was, it should be fine on the latest versions.

Sergio0694 · 2024-11-08T00:31:46Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <OutputPath>$(SolutionDir)$(Platform)\$(Configuration)\$(MSBuildProjectName)\</OutputPath>
+    <Configurations>Debug;Release;ReleaseStatic</Configurations>


We should also add:

<EmbedUntrackedSources>true</EmbedUntrackedSources>

Sergio0694 · 2024-11-08T00:32:03Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <OutputPath>$(SolutionDir)$(Platform)\$(Configuration)\$(MSBuildProjectName)\</OutputPath>
+    <Configurations>Debug;Release;ReleaseStatic</Configurations>


On .NET 8, we should also add:

<IsAotCompatible>true</IsAotCompatible> <DisableRuntimeMarshalling>true</DisableRuntimeMarshalling>

Sergio0694 · 2024-11-08T00:32:44Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />


Wrong version:

Suggested change

<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />

<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.1.6" />

Sergio0694 · 2024-11-08T00:34:24Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+    <WindowsSdkPackageVersion>10.0.22000.34</WindowsSdkPackageVersion>
+  </PropertyGroup>
+
+  <PropertyGroup>


For the .targets in the NuGet package, we should add this:

<WindowsMetadataReference Include="<WINMD_PATH>" IsOutOfProcess="true" />

Where "<WINMD_PATH>" is the right path to the .winmd in the NuGet package.

Sergio0694 · 2024-11-08T01:11:44Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>net6.0-windows10.0.22000.0;net8.0-windows10.0.22000.0</TargetFrameworks>


On second thought, I think we should do .NET 8 only.
.NET 6 is literally going EOL next Tuesday 😄

Sergio0694

Why did you remove WindowsSdkPackageVersion? We still need it, just set it to:

.53 for .NET 6
.54 for .NET 8

JohnMcPMS · 2024-11-11T23:52:04Z

Why did you remove WindowsSdkPackageVersion? We still need it, just set it to:

.53 for .NET 6

.54 for .NET 8

Does CsWinRT not choose the appropriate value by default based on its own version and the TFM?

Sergio0694 · 2024-11-11T23:56:29Z

No, it's the .NET SDK that picks the projection version, not CsWinRT. And we haven't shipped a .NET SDK using the latest projections yet, so we can just manually specify that version for now, and remove it in the future. But really there's no harm hardcoding it in projections projects, as long as you don't forget to go back and remove it or update it later on 🙂

…dling for 2.1 changes

Sergio0694 · 2024-11-12T20:07:02Z

...gement.Deployment.CsWinRTProjection/Microsoft.Management.Deployment.CsWinRTProjection.csproj

+    <!--
+    !!! Remove or update this on the next Microsoft.Windows.CsWinRT package version update. !!!
+    -->
+    <WindowsSdkPackageVersion>10.0.22000.54</WindowsSdkPackageVersion>


Suggested change

<WindowsSdkPackageVersion>10.0.22000.54</WindowsSdkPackageVersion>

<WindowsSdkPackageVersion>10.0.22000.53</WindowsSdkPackageVersion>

But why not the version that supports .NET 8 and UWP?

.53 also supports .NET 8. The UWP support is not exclusive to .54 (the phrasing in our release notes isn't entirely accurate). The .54 version just also has the projections for Windows.UI.Xaml.* types, but we're not using them here, so they're just not needed. Using .53 will still work just fine in UWP apps using .NET 9, don't worry 🙂

Sergio0694

LGTM!

Gaoyifei1011 · 2024-11-26T13:49:38Z

Change

Produce a CsWinRT projection for Microsoft.Management.Deployment. Move to CsWinRT 2.1.6 across the solution.

Microsoft Reviewers: Open in CodeFlow

I am glad that WinGet's deployment api uses the new CsWinRT, so would you like to ask if the new Projection dll with CsWinRT will be included in the winget nuget distribution in the next release?

========================

非常欣慰 WinGet 的 deployment api 使用新的 CsWinRT，所以想问一下，下一个版本会在 winget nuget 发行包中包含新带有 CsWinRT 的 Projection dll 吗？

Add CsWinRT projection producing project for deployment API

e7028e1

JohnMcPMS requested a review from a team as a code owner November 7, 2024 20:11

florelis reviewed Nov 7, 2024

View reviewed changes

florelis previously approved these changes Nov 7, 2024

View reviewed changes

Sergio0694 suggested changes Nov 8, 2024

View reviewed changes

microsoft-github-policy-service bot assigned JohnMcPMS Nov 8, 2024

microsoft-github-policy-service bot added Needs-Author-Feedback Issue needs attention from issue or PR author Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Nov 8, 2024

Sergio0694 suggested changes Nov 8, 2024

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Nov 8, 2024

JohnMcPMS added 2 commits November 8, 2024 14:53

PR feedback

8b1cfce

Attempt to move to CsWinRT 2.1.6

1cc2bf6

JohnMcPMS dismissed florelis’s stale review via 1cc2bf6 November 9, 2024 00:17

microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Nov 9, 2024

This comment has been minimized.

Sign in to view

Sergio0694 suggested changes Nov 9, 2024

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Nov 9, 2024

microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Nov 11, 2024

Disable CCW lookup table in more places and fix local testing script

fb59612

This comment has been minimized.

Sign in to view

Spelling, add back SDK versions, more fixier init script, fix ALC han…

7fe516a

…dling for 2.1 changes

This comment has been minimized.

Sign in to view

splelling

01c112f

Sergio0694 suggested changes Nov 12, 2024

View reviewed changes

microsoft-github-policy-service bot added Needs-Author-Feedback Issue needs attention from issue or PR author and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Nov 12, 2024

minus one

3886023

Sergio0694 approved these changes Nov 12, 2024

View reviewed changes

JohnMcPMS removed the Needs-Attention Issue needs attention from Microsoft label Nov 13, 2024

florelis approved these changes Nov 18, 2024

View reviewed changes

JohnMcPMS merged commit 5645e0c into microsoft:master Nov 18, 2024
9 checks passed

JohnMcPMS deleted the dep-proj branch November 18, 2024 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CsWinRT projection producing project for deployment API #4949

Add CsWinRT projection producing project for deployment API #4949

JohnMcPMS commented Nov 7, 2024 •

edited

Loading

florelis Nov 7, 2024

Sergio0694 left a comment

Sergio0694 Nov 8, 2024

JohnMcPMS Nov 8, 2024

Sergio0694 Nov 8, 2024

Sergio0694 Nov 8, 2024

Sergio0694 Nov 8, 2024

Sergio0694 Nov 8, 2024

Sergio0694 Nov 8, 2024

Sergio0694 Nov 8, 2024

This comment has been minimized.

Sergio0694 left a comment

JohnMcPMS commented Nov 11, 2024

Sergio0694 commented Nov 11, 2024

This comment has been minimized.

This comment has been minimized.

Sergio0694 Nov 12, 2024

JohnMcPMS Nov 12, 2024

Sergio0694 Nov 12, 2024

Sergio0694 left a comment

Gaoyifei1011 commented Nov 26, 2024

Change

Microsoft Reviewers: Open in CodeFlow

	<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.0.4" />
	<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.1.6" />

	<WindowsSdkPackageVersion>10.0.22000.54</WindowsSdkPackageVersion>
	<WindowsSdkPackageVersion>10.0.22000.53</WindowsSdkPackageVersion>

Add CsWinRT projection producing project for deployment API #4949

Add CsWinRT projection producing project for deployment API #4949

Conversation

JohnMcPMS commented Nov 7, 2024 • edited Loading

Change

Microsoft Reviewers: Open in CodeFlow

Choose a reason for hiding this comment

Sergio0694 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

Sergio0694 left a comment

Choose a reason for hiding this comment

JohnMcPMS commented Nov 11, 2024

Sergio0694 commented Nov 11, 2024

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sergio0694 left a comment

Choose a reason for hiding this comment

Gaoyifei1011 commented Nov 26, 2024

Change

Microsoft Reviewers: Open in CodeFlow

========================

JohnMcPMS commented Nov 7, 2024 •

edited

Loading