add installer index prefix to menu item (#169)

microsoft · Sep 15, 2021 · f4af949 · f4af949
1 parent a1dfc35
commit f4af949
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/WingetCreateCLI/Commands/NewCommand.cs b/src/WingetCreateCLI/Commands/NewCommand.cs
@@ -295,7 +295,7 @@ private static void DisplayInstallersAsMenuSelection(InstallerManifest installer
         private static List<string> GenerateInstallerSelectionList(List<Installer> installers, out Dictionary<string, Installer> installerSelectionMap)
         {
             installerSelectionMap = new Dictionary<string, Installer>();
-
+            int index = 1;
             foreach (Installer installer in installers)
             {
                 var installerTuple = string.Join(" | ", new[]
@@ -307,7 +307,9 @@ private static List<string> GenerateInstallerSelectionList(List<Installer> insta
                         installer.InstallerUrl,
                     }.Where(s => !string.IsNullOrEmpty(s)));
 
-                installerSelectionMap.Add(installerTuple, installer);
+                var installerMenuItem = string.Format(Resources.InstallerSelection_MenuItem, index, installerTuple);
+                installerSelectionMap.Add(installerMenuItem, installer);
+                index++;
             }
 
             List<string> selectionList = new List<string>() { Resources.AllInstallers_MenuItem };

diff --git a/src/WingetCreateCLI/Properties/Resources.Designer.cs b/src/WingetCreateCLI/Properties/Resources.Designer.cs
diff --git a/src/WingetCreateCLI/Properties/Resources.resx b/src/WingetCreateCLI/Properties/Resources.resx
@@ -769,4 +769,9 @@
   <data name="DefenderVirus_ErrorMessage" xml:space="preserve">
     <value>Operation did not complete successfully because the downloaded file contains a virus or potentially unwanted software. For more information on potentially unwanted software and what options are available, see https://aka.ms/winget-create-security</value>
   </data>
+  <data name="InstallerSelection_MenuItem" xml:space="preserve">
+    <value>INSTALLER {0}: {1}</value>
+    <comment>{0} - represents the installer index number
+{1} - represents the associated installer metadata</comment>
+  </data>
 </root>