Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Command does not show warning when forgetting to include --url flag. #89

Closed
ryfu-msft opened this issue Jun 19, 2021 · 0 comments · Fixed by #104
Closed

Update Command does not show warning when forgetting to include --url flag. #89

ryfu-msft opened this issue Jun 19, 2021 · 0 comments · Fixed by #104
Assignees
@ryfu-msft
Labels
Issue-Bug Resolution-Fix-Committed
Milestone
1.0 Create

Comments

@ryfu-msft
Copy link
Contributor

Update command fails to show the user an error message when they forget to include the --url flag when specifying the installer URL.

Expected behavior:
Show an error message to include the flag or that the format of the parameter is incorrect.
@ryfu-msft ryfu-msft self-assigned this Jun 19, 2021
@ghost ghost added the Needs-Triage label Jun 19, 2021
@ryfu-msft ryfu-msft added this to the v.Next - `winget create` milestone Jun 19, 2021
@ryfu-msft ryfu-msft modified the milestones: v.Next - `winget create`, v1.0 - `winget create` Jun 29, 2021
@ryfu-msft ryfu-msft mentioned this issue Jul 7, 2021
Merged
@ghost ghost added the In-PR label Jul 7, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryfu-msft ryfu-msft

Labels
Issue-Bug Resolution-Fix-Committed
Projects
None yet
Milestone
1.0 Create
Development

Successfully merging a pull request may close this issue.

Handle redirect urls and unbounded positional arguments microsoft/winget-create
1 participant
@ryfu-msft