Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle redirect urls and unbounded positional arguments #104

Merged
merged 8 commits into from
Jul 7, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jul 7, 2021

This pull request addresses the following issues:
Fixes #89
Fixes #27

Changes:

  • Allows for redirect urls to be downloaded and parsed. The maximum number of redirects is 2.
  • Adds additional hidden parameter that captures all unbound parameters after the first positional argument in the update and submit command. This is used to check if any invalid parameters are included and let the user know if they might have forgotten to include a flag.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from palenshus July 7, 2021 01:21
@ryfu-msft ryfu-msft requested a review from a team as a code owner July 7, 2021 01:21
@ghost ghost added the Issue-Bug label Jul 7, 2021
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost added the Needs-Author-Feedback label Jul 7, 2021
@ghost ghost removed the Needs-Author-Feedback label Jul 7, 2021
@ryfu-msft ryfu-msft requested a review from palenshus July 7, 2021 16:55
@palenshus
Copy link
Contributor

palenshus commented Jul 7, 2021

    public const string TestMsixManifest = "WingetCreateE2E.MsixTest.yaml";

Why is this back? #Closed


Refers to: src/WingetCreateTests/WingetCreateTests/TestConstants.cs:69 in acda858. [](commit_id = acda858, deletion_comment = False)

@ryfu-msft
Copy link
Contributor Author

    public const string TestMsixManifest = "WingetCreateE2E.MsixTest.yaml";

Why is this back?

Refers to: src/WingetCreateTests/WingetCreateTests/TestConstants.cs:69 in 8d84419. [](commit_id = 8d84419, deletion_comment = False)

I had to reset some files, but you're probably referencing an old commit. It shouldn't be there.

@ryfu-msft ryfu-msft merged commit 0b90d07 into main Jul 7, 2021
@ryfu-msft ryfu-msft deleted the RedirectHttp branch July 7, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants