Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prompts for optional string fields #106

Merged
merged 7 commits into from
Jul 9, 2021
Merged

Add prompts for optional string fields #106

merged 7 commits into from
Jul 9, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jul 7, 2021 •
edited
Loading

  • Adds the basic prompting flow that prompts the user if they would like to add optional fields to their manifest.
  • This PR only prompts for basic string fields.
  • Also fixes the command line parser to handle -? without throwing an error.
  • Moves the validation so that it occurs within the loop and prior to confirmation by the user.

The following optional fields are now customizable in the new command:

  • PublisherUrl
  • PublisherSupportUrl
  • PrivacyUrl
  • Author
  • PackageUrl
  • LicenseUrl
  • Copyright
  • CopyrightUrl
  • Description
  • Moniker
  • Tags
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from palenshus July 7, 2021 22:12
@ryfu-msft ryfu-msft requested a review from a team as a code owner July 7, 2021 22:12
@ryfu-msft ryfu-msft linked an issue Jul 7, 2021 that may be closed by this pull request
wingetcreate should prompt for optional fields. #37
Closed
@ryfu-msft ryfu-msft requested a review from palenshus July 8, 2021 21:27
palenshus
palenshus approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft requested a review from palenshus July 9, 2021 00:30
@ryfu-msft ryfu-msft merged commit f7b91a7 into main Jul 9, 2021
@ryfu-msft ryfu-msft deleted the OptionalFields branch July 9, 2021 00:43
@ryfu-msft ryfu-msft mentioned this pull request Jul 19, 2021
Closed
@ryfu-msft ryfu-msft linked an issue Jul 19, 2021 that may be closed by this pull request
Add the licence-url field #35
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon left review comments

@palenshus palenshus Awaiting requested review from palenshus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wingetcreate should prompt for optional fields. Add the licence-url field
3 participants
@ryfu-msft @palenshus @denelon