-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Installer Url Matching for Update Command and Improve Error Messages #108
Conversation
Check Firefox to see how we handle apps that differ only by locale #Closed |
@ryfu-msft, how'd this go? In reply to: 879612294 In reply to: 879612294 |
As expected, installer nodes that differed only by locale had a similar behavior to installer nodes that only differed by scope. We will need to investigate the heuristics to see if we can catch these cases. In reply to: 880261055 In reply to: 880261055 In reply to: 880261055 |
Azure Pipelines successfully started running 1 pipeline(s). |
src/WingetCreateTests/WingetCreateTests/UnitTests/UpdateCommandTests.cs
Outdated
Show resolved
Hide resolved
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
1 similar comment
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
src/WingetCreateTests/WingetCreateTests/UnitTests/PackageParserTests.cs
Outdated
Show resolved
Hide resolved
This can be static In reply to: 881127753 In reply to: 881127753 In reply to: 881127753 Refers to: src/WingetCreateCLI/Commands/UpdateCommand.cs:334 in 1000920. [](commit_id = 1000920, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request addresses the following:
Fixes #105
Fixes #107
We have discovered that there are some installers that are incorrectly identified by their manifest. When looking at the installers, they may have an architecture or installer type that differs from what is specified in the manifest, leading to an update command failure due to mismatched installers.
Since many installer URLs follow the pattern of including their architecture in their URL, we try to mitigate this issue by looking for any architectures stated in the installer URL. Winget-Create will attempt to match new installer URLs with their existing installers based on whether an architecture could be identified from the installer URL. If no architecture is identified, Winget-Create will resort to its normal flow and compare installers based on the architecture & installer type parsed from the package.
Changes:
Testing:
Microsoft Reviewers: Open in CodeFlow