Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Navigational Menu to Edit Optional Installer Fields #133

Merged
merged 19 commits into from
Aug 25, 2021
Merged

Add Navigational Menu to Edit Optional Installer Fields #133

merged 19 commits into from
Aug 25, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Aug 12, 2021 •
edited by ghost
Loading

This pull request completes the optional feature and resolves #37

Changes:

  • Adds a navigational menu to allow users to either select all installers, or an individual installer to edit.
  • Once the installer(s) is selected, a selection menu will be shown to the user listing out all optional installer fields for the user to select and edit.
  • The field list will change depending on the installertype of the installer.
  • Certain fields are automatically restricted from being edited by the user by default (InstallerURL, InstallerSha256, SignatureSha256, ProductCode (unless MSI), and PackageFamilyName(unless MSIX))
  • Refactor the prompting methods into a new class called PromptHelper.cs
  • PromptAndSetPropertyValue() method is the main prompting method and should now be able to handle any field regardless of the field type.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner August 12, 2021 17:37
@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 12, 2021
@palenshus
Copy link
Contributor

palenshus commented Aug 16, 2021 •
edited
Loading

// Copyright (c) Microsoft. All rights reserved.

Looks like only white-space changes in here?

In reply to: 899274173

In reply to: 899274173

Refers to: src/WingetCreateCore/Common/GitHub.cs:1 in e8bd161. [](commit_id = e8bd161, deletion_comment = True)

palenshus
palenshus previously requested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs-Author-Feedback label Aug 19, 2021
@ryfu-msft
Copy link
Contributor Author

// Copyright (c) Microsoft. All rights reserved.

reverted

In reply to: 899274173

Refers to: src/WingetCreateCore/Common/GitHub.cs:1 in e8bd161. [](commit_id = e8bd161, deletion_comment = True)

@palenshus palenshus dismissed their stale review August 20, 2021 23:40

revoking review

palenshus
palenshus previously requested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs-Author-Feedback label Aug 23, 2021
@palenshus palenshus dismissed their stale review August 23, 2021 20:22

revoking review

palenshus
palenshus requested changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs-Author-Feedback label Aug 23, 2021
palenshus
palenshus approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft enabled auto-merge (squash) August 25, 2021 21:52
@ryfu-msft ryfu-msft merged commit c03c4bf into main Aug 25, 2021
@ryfu-msft ryfu-msft deleted the installerOptional branch August 25, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon left review comments

@palenshus palenshus palenshus approved these changes

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wingetcreate should prompt for optional fields.
3 participants
@ryfu-msft @palenshus @denelon