Handle exception when creating a reference immediately after creating fork #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
palenshus
reviewed
Aug 23, 2021
palenshus
reviewed
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
Description of Bug:
A weird behavior occurs when trying to create a reference to a forked repo immediately after creating the forked repo. This issue does not repro if the forked winget-pkgs repo had already existed previously.
The error in the linked issue #130 is actually caused by the issue stated above but is inaccurately reported because the user did not provide a token with "delete_repo" permission, which is needed to clean up the forked repo if there is a failure that occurs during PR submission.
Changes:
Microsoft Reviewers: Open in CodeFlow