Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate manifest in interactive menu #174

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Validate manifest in interactive menu #174

merged 2 commits into from
Sep 23, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Sep 23, 2021 •
edited by ghost
Loading

Resolves #172

Changes:

  • Adds an extra validate manifest step prior to showing the menu selection of manifests. This informs the user if there's anything invalid and needs to be fixed.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft added this to the v1.0-Create milestone Sep 23, 2021
@ryfu-msft ryfu-msft requested a review from a team as a code owner September 23, 2021 17:37
@ghost ghost added the Issue-Bug label Sep 23, 2021
palenshus
palenshus approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit a230d51 into main Sep 23, 2021
@ryfu-msft ryfu-msft deleted the validateInteractive branch September 23, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palenshus palenshus palenshus approved these changes

Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
1.0 Create
Development

Successfully merging this pull request may close these issues.

Interactive update menu does not validate manifest
2 participants
@ryfu-msft @palenshus