-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info command to display key information #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love everything about having a --info
menu similar to winget, but i'm a little hesitant about overriding the command parser to achieve parity. The workaround of appending --help
also feels weird to me as it seems to be changing the intended behavior of the library and I don't know what consequences that may have on other things.
I know we should try to align with winget-cli as much as possible but if we can achieve the same end result by simply adding a wingetcreate info
command instead, that may be an easier solution. That would also make it easier for testing so we could verify what is displayed. Thoughts?
I would've loved to keep
Sounds good. This will also make it easier in future to implement some common options for all commands (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more nits and we can get this checked in 😄
I'll start working on getting this aka.ms links ready
src/WingetCreateTests/WingetCreateTests/UnitTests/CommonTests.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Having some issues with some internal builds, will investigate and check this PR in when it starts passing. Thanks for the awesome contribution @mdanish-kh! (also, aka.ms links that you mentioned above are all now live) |
wingetcreate --info
option #460This PR adds support for root options for the CLI and the following:
@ryfu-msft Can you kindly create these short URLs if you approve of them☺️
https://aka.ms/winget-create-license → https://github.com/microsoft/winget-create/blob/main/LICENSE
https://aka.ms/winget-create-privacy → https://github.com/microsoft/winget-create/blob/main/PRIVACY.md
https://aka.ms/winget-create-3rdPartyNotice → https://github.com/microsoft/winget-create/blob/main/NOTICE.txt
Microsoft Reviewers: Open in CodeFlow