Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path search #135

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Dec 6, 2024


Addresses issue #105

Microsoft Reviewers: Open in CodeFlow

@Gijsreyn Gijsreyn force-pushed the fix-vscode-search-path branch from 7cc1632 to d411df7 Compare December 11, 2024 01:12
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Dec 11, 2024
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Dec 11, 2024

Thanks for the comments @ryfu-msft . I have rewritten the logic and grabbed most of the old stuff from you. Looking at the code from: https://github.com/desktop/desktop/blob/development/app/src/lib/editors/win32.ts, I included the WOW6432Node path as well. Let me know what you think.

On a 64-bit system, I'm getting this:

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Dec 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Dec 21, 2024
@Gijsreyn
Copy link
Contributor Author

Sorry to bug you both @denelon or @stephengillie . Still waiting for this one to get pulled in :)

@denelon
Copy link
Contributor

denelon commented Feb 13, 2025

@AmelBawa-msft can you take a look at this one?

@Gijsreyn I'm working on adjusting to Ryan's departure. @AmelBawa-msft will be taking point on this repository for a while. He'll just need some time to get up to speed here. We're going to discuss this more broadly over the next few business days.

Copy link

@AmelBawa-msft AmelBawa-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM! Thank you everyone for contributing and addressing the comments.

✅ Tested the updated logic locally

Write-Host $(Get-VSCodeCLIPath)
# the path to the bin\code.cmd

@AmelBawa-msft AmelBawa-msft merged commit c9cdd77 into microsoft:main Feb 13, 2025
4 checks passed
@Gijsreyn Gijsreyn deleted the fix-vscode-search-path branch February 14, 2025 06:06
@Gijsreyn
Copy link
Contributor Author

@denelon I understand, thanks for the response. And @AmelBawa-msft, welcome - much appreciated for pulling it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.VSCode.Dsc fails to detect presence of VSCode on my Windows 11 arm virtual machine
5 participants