-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path search #135
Fix path search #135
Conversation
7cc1632
to
d411df7
Compare
Thanks for the comments @ryfu-msft . I have rewritten the logic and grabbed most of the old stuff from you. Looking at the code from: https://github.com/desktop/desktop/blob/development/app/src/lib/editors/win32.ts, I included the WOW6432Node path as well. Let me know what you think. On a 64-bit system, I'm getting this: |
…winget-dsc into fix-vscode-search-path
Sorry to bug you both @denelon or @stephengillie . Still waiting for this one to get pulled in :) |
@AmelBawa-msft can you take a look at this one? @Gijsreyn I'm working on adjusting to Ryan's departure. @AmelBawa-msft will be taking point on this repository for a while. He'll just need some time to get up to speed here. We're going to discuss this more broadly over the next few business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you everyone for contributing and addressing the comments.
✅ Tested the updated logic locally
Write-Host $(Get-VSCodeCLIPath)
# the path to the bin\code.cmd
@denelon I understand, thanks for the response. And @AmelBawa-msft, welcome - much appreciated for pulling it in! |
Addresses issue #105
Microsoft Reviewers: Open in CodeFlow