Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miller.Miller to 6.10.0 #132018

Merged
merged 1 commit into from
Jan 2, 2024
Merged

update Miller.Miller to 6.10.0 #132018

merged 1 commit into from
Jan 2, 2024

Conversation

rursprung
Copy link
Contributor

@rursprung rursprung commented Dec 28, 2023

the manifest has been created using the following command:

wingetcreate update miller.miller -v 6.10.0 -u https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-amd64.zip

the ReleaseNotesUrl has been manually added as wingetcreate update does not yet support release notes (see also
microsoft/winget-create#497).

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

the manifest has been created using the following command:
```bash
wingetcreate update miller.miller -v 6.10.0 -u https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-386.zip https://github.com/johnkerl/miller/releases/download/v6.10.0/miller-6.10.0-windows-amd64.zip
```

the `ReleaseNotesUrl` has been manually added as `wingetcreate update`
does not yet support release notes (see also
microsoft/winget-create#497).
@rursprung
Copy link
Contributor Author

@microsoft-github-policy-service agree

@rursprung
Copy link
Contributor Author

@microsoft-github-policy-service agree

(didn't i just do that...?)

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Dec 28, 2023
@rursprung
Copy link
Contributor Author

as per @stephengillie's comment here the validation error is to be expected: #123507 (comment)

@stephengillie stephengillie self-assigned this Dec 29, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Dec 29, 2023
@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Dec 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 29, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 29, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 65fd8d8 into microsoft:master Jan 2, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@rursprung rursprung deleted the update-miller.miller-to-6.10.0 branch January 2, 2024 19:46
@rursprung rursprung mentioned this pull request Jan 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants