Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Zwylair.BetterDiscordAutoInstaller version 1.3.0 #216722

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

New package: Zwylair.BetterDiscordAutoInstaller version 1.3.0 #216722

wants to merge 5 commits into from
+54 −0

Conversation

ForeverFloating
Copy link
Contributor

@ForeverFloating ForeverFloating commented Jan 25, 2025 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with komac v2.9.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 25, 2025
@ForeverFloating
Update and rename Zwylair.BetterDiscordAutoInstaller.locale.en-US.yam…
94b474c 
…l to Zwylair.BetterDiscordAutoInstaller.locale.en.yaml

Changed name of file to correspond with locale.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 25, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 25, 2025
@ForeverFloating
Update Zwylair.BetterDiscordAutoInstaller.installer.yaml
c7be3f5 
Removed experimental "Channel" field
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 25, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 25, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 25, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 25, 2025
@Trenly
Copy link
Contributor

Trenly commented Jan 26, 2025

[Policy] Zip Binary

@microsoft-github-policy-service microsoft-github-policy-service bot added zip-binary Depends on library files that aren't available via symlink Needs-Author-Feedback This needs a response from the author. labels Jan 26, 2025
@ForeverFloating
Update Zwylair.BetterDiscordAutoInstaller.installer.yaml
3bfe532 
Added `ArchiveBinariesDependOnPath` field
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error New-Package labels Jan 26, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 26, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 965.)

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Executable-Error zip-binary Depends on library files that aren't available via symlink labels Feb 5, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 5, 2025 •
edited
Loading

Manual Validation ended with:

PS C:\Users\User\Desktop> C:\Users\User\AppData\Local\Microsoft\WinGet\Links\BetterDiscordAutoInstaller-v1.3.0.exe --version
Program 'BetterDiscordAutoInstaller-v1.3.0.exe' failed to run: The specified executable is not a valid application for this OS platform.At line:1 char:1

(Automated response - build 977.)

Edit:
Hi @ForeverFloating,

This error means that another InstallerType is needed. More specifically, this appears to be an EXE nested inside a ZIP. Changing the filename back to BetterDiscordAutoInstaller-v1.3.0.zip allowed me to unzip it:
image
Inside the inner folder are the EXEs:
image

2 of the applications appear to require VCRedist:
image
image

The 3rd appeared to operate normally without the framework:
image

stephengillie
stephengillie requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error means that another InstallerType is needed. More specifically, this appears to be an EXE nested inside a ZIP. Changing the filename back to BetterDiscordAutoInstaller-v1.3.0.zip allowed me to unzip it:
image
Inside the inner folder are the EXEs:
image

  • I'm not sure that this will work, and I'm not sure if this is the correct way to do it. I'm using our schema for guidance.
  • Which EXE is the main one for this application? I believe it should be listed in the RelativeFilePath.

...z/Zwylair/BetterDiscordAutoInstaller/1.3.0/Zwylair.BetterDiscordAutoInstaller.installer.yaml
PackageVersion: 1.3.0
Installers:
- Architecture: x64
InstallerType: portable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerType: portable
InstallerType: zip
NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: "BetterDiscordAutoInstaller v1.3.0\\main.exe"
# PortableCommandAlias:

I'm not sure that this will work, due to the spaces in the RelativeFilePath. I believe spaces might not be allowed there.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @ForeverFloating,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 5, 2025
stephengillie
stephengillie requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 of the applications appear to require VCRedist:
image
image

I'm not sure if the framework is needed here. These applications might not be meant to be run directly. What are your thoughts?

(edit: clarity)

...z/Zwylair/BetterDiscordAutoInstaller/1.3.0/Zwylair.BetterDiscordAutoInstaller.installer.yaml

PackageIdentifier: Zwylair.BetterDiscordAutoInstaller
PackageVersion: 1.3.0
Installers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installers:
Dependencies:
PackageDependencies:
- PackageIdentifier: Microsoft.VCRedist.2015+.x64
Installers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ForeverFloating ForeverFloating

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ForeverFloating @wingetbot @Trenly @stephengillie