Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spice Guest Tools 0.141 #29306

Closed
wants to merge 1 commit into from
Closed

Added Spice Guest Tools 0.141 #29306

wants to merge 1 commit into from

Conversation

sootysec
Copy link
Contributor

@sootysec sootysec commented Oct 4, 2021

Signed-off-by: Daniel Sutton [email protected]

  • [x ] Have you signed the Contributor License Agreement?
  • [ x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [x ] Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Signed-off-by: Daniel Sutton <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jedieaston jedieaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't take installers right now that install drivers which require the user to trust a certificate (since that makes it not silent). See microsoft/winget-cli#615 (comment) for some information.

image

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Oct 4, 2021
@sootysec
Copy link
Contributor Author

sootysec commented Oct 4, 2021

@jedieaston Thanks for the feedback, closing.

@sootysec sootysec closed this Oct 4, 2021
@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 4, 2021
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 4, 2021
@ghost ghost assigned sootysec Oct 4, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

Hello @ducksecops,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 4, 2021
kevinoid added a commit to kevinoid/winget-pkgs that referenced this pull request Dec 6, 2021
Note: May not be suitable for inclusion in winget-pkgs due to requiring
user interaction for driver certificate trust confirmation:
microsoft#29306 (review)

Waiting on
microsoft/winget-cli#823 (comment)

Signed-off-by: Kevin Locke <[email protected]>
kevinoid added a commit to kevinoid/winget-pkgs that referenced this pull request Dec 6, 2021
Note: May not be suitable for inclusion in winget-pkgs due to requiring
user interaction for driver certificate trust confirmation:
microsoft#29306 (review)

Waiting on
microsoft/winget-cli#823 (comment)

Signed-off-by: Kevin Locke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants