Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - Split 7-Zip Alpha from 'stable' releases #3746

Closed
wants to merge 3 commits into from

Conversation

peterlewis
Copy link
Contributor

@peterlewis peterlewis commented Sep 26, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Can I suggest that the maintainers consider whether splitting 7-Zip alpha releases from the 'stable' non-alpha releases, might be a good idea? I certainly prefer to install a stable, non-alpha release, wherever possible and I imagine there are others who might be keen on the idea, also...

Would welcome thoughts on this!

Thanks,

Peter

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Sep 26, 2020

peterlewis The package manager bot determined there was an issue with the pull request. Make sure the manifest file is under the manifests\publisher\appname.
For details on the error, see the details link below in the build pipeline.

@yigitemres
Copy link
Contributor

Generally, this repo doesn't allow modifying more than one file (creating, changing etc.). It will be good to doing separate prs.

@peterlewis
Copy link
Contributor Author

peterlewis commented Sep 27, 2020

Thanks, @yigitemres! I appreciate that helpful feedback! :) At the moment this is still very much draft and has been done to highlight what I had mentioned in microsoft/winget-cli#147, namely:

Pinging @KevinLaMS and @denelon for an update here. I went to install 7zip and found that it would be an alpha version (20.0.0-alpha). This is not something I want to install on my development machine and expected that I would be installing the latest stable release of 7zip (19.00)... Can we please revert microsoft/winget-pkgs#2088?

I agree. Can we at least, for now, consider adopting the same behaviour as is done for Visual Studio Code to differentiate it from Visual Studio Code Insiders?

I've drafted a PR that follows the example of VSCode/VSCode Insiders and that I believe would sort the 7-Zip issue that @tusharb86 raised. Would welcome thoughts from all (@KevinLaMS and @denelon too, perhaps?).

If this is something that the maintainers might entertain as a possibility then can happily split this PR into two, though considering the PR is performing a single action (i.e. splitting alpha releases from stable releases) then, to me, it does make more sense to be in a single PR. However, I don't make the rules and am more than happy to go with the flow, on that! :)

For now, I'm more than happy to close this, so as to not clutter up the PRs, if you like?

@KevinLaMS
Copy link
Contributor

I think it would be fine to create a new -alpha version until there is scope working.
i would use a -alpha following the pattern VSCode did

C:\Users\kevinla>winget search vscode
Name Id Version Match Source

Visual Studio Code Microsoft.VisualStudioCode 1.49.1.58bb7b2331 Moniker: vscode winget
Visual Studio Code - Inside… Microsoft.VisualStudioCodeIn… 1.50.14.635cfbcd0f Moniker: vscode-insiders

the easiest way to do this would be to add a new manifest, then we would delete the alpha version.

Also note one of your manifests have a type apha.

Id: 7zip.7zip
Name: 7Zip
AppMoniker: 7zip
Id: 7zip.7zipApha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Id: 7zip.7zipApha
Id: 7zip.7zipAlpha

@peterlewis
Copy link
Contributor Author

That's great, thanks for that @KevinLaMS. I'll sort out a couple of PRs for both addition of alpha version and deletion of the existing YAMLs.

Thanks for the note regarding the formatting. I simply transposed the existing YAMLs to a new directory, so may have transposed issues along with those.

Closing this draft PR, now! 👍

Thanks,

Peter

@peterlewis peterlewis closed this Sep 27, 2020
@peterlewis peterlewis deleted the patch-2 branch September 27, 2020 17:09
@peterlewis
Copy link
Contributor Author

PR for alpha branch is in as #3756

@peterlewis peterlewis changed the title Split 7-Zip Alpha from 'stable' releases Proposal - Split 7-Zip Alpha from 'stable' releases Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants