-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal - Split 7-Zip Alpha from 'stable' releases #3746
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
peterlewis The package manager bot determined there was an issue with the pull request. Make sure the manifest file is under the manifests\publisher\appname. |
Generally, this repo doesn't allow modifying more than one file (creating, changing etc.). It will be good to doing separate prs. |
Thanks, @yigitemres! I appreciate that helpful feedback! :) At the moment this is still very much draft and has been done to highlight what I had mentioned in microsoft/winget-cli#147, namely:
If this is something that the maintainers might entertain as a possibility then can happily split this PR into two, though considering the PR is performing a single action (i.e. splitting alpha releases from stable releases) then, to me, it does make more sense to be in a single PR. However, I don't make the rules and am more than happy to go with the flow, on that! :) For now, I'm more than happy to close this, so as to not clutter up the PRs, if you like? |
I think it would be fine to create a new -alpha version until there is scope working. C:\Users\kevinla>winget search vscode
|
Id: 7zip.7zip | ||
Name: 7Zip | ||
AppMoniker: 7zip | ||
Id: 7zip.7zipApha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id: 7zip.7zipApha | |
Id: 7zip.7zipAlpha |
That's great, thanks for that @KevinLaMS. I'll sort out a couple of PRs for both addition of alpha version and deletion of the existing YAMLs. Thanks for the note regarding the formatting. I simply transposed the existing YAMLs to a new directory, so may have transposed issues along with those. Closing this draft PR, now! 👍 Thanks, Peter |
PR for alpha branch is in as #3756 |
winget validate <manifest>
, where<manifest>
is the name of the manifest you're submitting?winget install -m <manifest>
?Can I suggest that the maintainers consider whether splitting 7-Zip alpha releases from the 'stable' non-alpha releases, might be a good idea? I certainly prefer to install a stable, non-alpha release, wherever possible and I imagine there are others who might be keen on the idea, also...
Would welcome thoughts on this!
Thanks,
Peter
Microsoft Reviewers: Open in CodeFlow