Remove ContainsTarget on onenotePage navigation properties #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
C# Generation
Generation for navigation properties to a single entity (not in a collection) appears to be setup well. By removing ContainsTarget for this scenario, the existing method call pattern will stay the same:
client.Users[""].Onenote.Pages[""].Request().Expand(x => x.ParentSection).GetAsync();
The difference is that it will be technically a breaking change as
client.Users[""].Onenote.Pages[""]
will change from returning anIOnenotePageRequestBuilder
to aIOnenotePageWithReferencesRequestBuilder
.IOnenotePageWithReferenceRequestBuilder
enablesclient.Users[""].Onenote.Pages[""].Reference.Request()
which hasDeleteAsync()
for removing references andPutAsync(string)
for adding references.GetAsync()
,CreateAsync()
,DeleteAsync()
, andUpdateAsync()
are still available fromclient.Users[""].Onenote.Pages[""].Request()
with this change.Quick dump. We have an issue when this type of change happens when we remove ContainsTarget=true from navigation properties of collections.
Java generation
TBD