Migrate to ZendFramework to Symfony #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with
composer create-project symfony/skeleton:"6.4.*" catalog-symfony
then manually merged into the application directory.
For now we can skip any reorganization, addition of namespaces, and other refactoring of the main data model while getting controllers and views ported over to Symfony.
The use of '/' as a separator in subcomponents turned out to be a bad idea
because these slashes need to be escaped as %2F, but these escaped slashes
can interfere with some webserver configuration.
For example Apache redirects require the NE "No Escape" option to preserve
%2F slashes without double-escaping:
# Redirect all traffic to https
#
# We're using mod_rewrite here rather than mod_alias's `Redirect`
# because mod_alias doesn't allow the "NE" == "noescape" parameter
# that allows URLs includinging encoded slashes (%2F) to be returned
# without double-escaping.
RewriteRule .* https://<%= node["app_domain"] %>$0 [L,R=301,NE]
Similarly, Symfony refuses to allow slashes in parameters passed as tokens
in routes.
To address this problematic choice, use '.' as a separator of
sub-components in identifiers. Periods don't require special escaping in
URLs or database queries, though they do in regular expressions.
Other actions are still a work in progress.
Many parts still broken: - Add sections - Print view - JS weekly calendar - email functions This commit was getting to be too big to keep track of, so will break out further work into subsequent commits.
…years. Will re-add this functionality once a replacement library is identified which can be added without bringing in ancient versions of jqueryui.
Unfortunately, the normal way of using AssetMapper to include it as a module was failing because jQuery isn't registered in the global scope at the point that jquery-ui gets imported. My work-around was to add a line at the top of jquery-ui.js to import jquery and make the variable available to the library for modification. This is a bit of a hack, but get both libraries loaded and available for now.
This version of PHP still requires oci8-3.2.1. When PHP is upgraded I can update to oci8-3.4.0.
The previous lines:
_defaults:
autoconfigure: true # Automatically registers your services as commands, event subscribers, etc
ensure that these are registered based on the classes that they extend, so
there is no need to explicitly configure these tags.
https://symfonycasts.com/screencast/symfony-fundamentals/autoconfiguration#how-does-this-work-the-black-magic-behind
…ally. osid_NotFoundException are converted to NotFoundHttpException and give a 404 status code to clients. osid_InvalidArgumentException are converted to BadRequestHttpException and give a 400 status code to clients. These central conversions of exceptions uncaught in the controller means that the controller methods don't have to do as much exception handling except for cases where they want to ignore certain exceptions and continue.
Made these symfony console commands and made the CatalogSyncer library as set of services. Still need to update the commands to use console outputs and they mailer service. Also should specify return types in the interfaces to be more strict.
This uses an encoded JSON array to pass from shell, to YAML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47.