Set public key from private key in DNSKEY instead of copying it from DNSKEY to private key #1560
Conversation
baest
force-pushed
the
set_public_key_from_private_key
branch
from
4c2c49c
to
afda3af
Compare
baest
force-pushed
the
set_public_key_from_private_key
branch
from
afda3af
to
b680beb
Compare
…DNSKEY to private key Previously when loading a PrivateKey into a DNSKEY we would return the PrivateKey with the PublicKey set from the DNSKEY struct. Now that behaviour is flipped and the PublicKey is taken from the PrivateKey and set in the DNSKEY. It will now fail if the algorithm or PublicKey in the DNSKEY doesn't match what is loaded in the input file
baest
force-pushed
the
set_public_key_from_private_key
branch
from
b680beb
to
d9e2afe
Compare
| @@ -48,27 +48,29 @@ const ( | |||
|
|
|||
| // Errors defined in this package. | |||
| var ( | |||
| ErrAlg error = &Error{err: "bad algorithm"} // ErrAlg indicates an error with the (DNSSEC) algorithm. | |||
There was a problem hiding this comment.
I added a new entry and my editor reformatted the code to align better. I thought it an ok change so I kept it, but I can take this out if needed.
|
what motivates this change? |
I have private keys stored in a database and I need to load those, get the public key from it and also use that to create the DS. The previous version took the public key from the DNSKEY object and then copied it into the private key. To me it makes more sense to just keep the public key stored inside the private key (and it also serves my needs to be fair). |
|
Hi, would you consider merging this? It is an implementation of #1558 |
Previously when loading a PrivateKey into a DNSKEY we would return the PrivateKey with the PublicKey set from the DNSKEY struct. Now that behaviour is flipped and the PublicKey is taken from the PrivateKey and set in the DNSKEY.