-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std/cli, move std/getopt there #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Replaces #1027 |
build fails |
fare
force-pushed
the
cli
branch
3 times, most recently
from
November 28, 2023 13:22
d7b9d66
to
6bb2277
Compare
It was a rebasing issue (I was using |
Also avoiding |
Import a bunch of CLI utilities from gerbil-utils into std/cli; tweak them, document them, test them: - multicall to support multiple subcommands in a more modular way - getopt translation to Scheme calling convention - print-exit to print results of Scheme computation at the CLI - shell to support escaping strings for the shell Add a few corresponding utilities to std/error. Move std/getopt to std/cli/getopt with its brothers; leave a compatibility shim at std/getopt. Use std/cli/getopt everywhere instead of std/getopt. Update documentation.
chiefnoah
reviewed
Nov 29, 2023
PTAL |
chiefnoah
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import a bunch of CLI utilities from gerbil-utils into std/cli; tweak them, document them, test them:
Add a few corresponding utilities to std/error.
Move std/getopt to std/cli/getopt with its brothers; leave a compatibility shim at std/getopt.
Use std/cli/getopt everywhere instead of std/getopt.
Update documentation.