Bump min iOS version to 11 #1383

navaronbracke · 2023-10-08T20:20:12Z

This PR bumps the minimum iOS version to version 11.0, which is the minimum required by the current stable releases.
Flutter 3.0 was the last release to support iOS 10.

I also fixed two warnings in the plugin:

a deprecated method for iOS 10 that could be removed
a warning about passing null to an array of NSURL, which did not allow null

Fixes #1382

…ted describeEnum()

…ectInputEvents to example

navaronbracke · 2023-10-08T20:20:39Z

analysis_options.yaml

@@ -35,8 +35,7 @@ linter:
    - diagnostic_describe_all_properties
    - empty_statements
    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
+    - collection_methods_unrelated_type


The two lints are deprecated and are replaced by this new one

navaronbracke · 2023-10-08T20:22:09Z

example/ios/Runner/Info.plist

@@ -50,5 +50,9 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<false/>
+	<key>CADisableMinimumFrameDurationOnPhone</key>


This was generated by Flutter's tooling.

navaronbracke · 2023-10-08T20:23:37Z

lib/src/file_picker_io.dart

@@ -73,7 +72,7 @@ class FilePickerIO extends FilePicker {
    bool? withData,
    bool? withReadStream,
  ) async {
-    final String type = describeEnum(fileType);
+    final String type = fileType.name;


decribeEnum() has been deprecated for a while, in favor of the name property on enums themselves.

navaronbracke · 2023-10-08T20:25:25Z

ios/Classes/FilePickerPlugin.m

@@ -484,7 +460,7 @@ -(void)picker:(PHPickerViewController *)picker didFinishPicking:(NSArray<PHPicke
    __block NSError * blockError;

    for (NSInteger index = 0; index < results.count; ++index) {
-        [urls addObject:[NSNull null]];
+        [urls addObject:[NSURL URLWithString:@""]];


The warning came from the fact that the urls array did not accept null. Since the first element in the array is replaced, I just added an empty NSURL. (and rather than using new I went with URLWithString, as the former also generates a warning)

navaronbracke · 2023-10-08T20:26:03Z

ios/Classes/FilePickerPlugin.m

-        Log(@"Multiple file selection is only supported on iOS 11 and above. Single selection will be used.");
-    }
-
+    self.documentPickerController.allowsMultipleSelection = allowsMultipleSelection;    


Removing availability checks for iOS 11.0, as that is now the minimum

navaronbracke · 2023-10-10T08:21:48Z

example/ios/Flutter/Flutter.podspec

@@ -1,17 +1,17 @@
 #


This is a generated file and should not be checked in, will fix this as well.

navaronbracke · 2023-10-10T08:58:14Z

example/ios/Flutter/Flutter.podspec

This file is autogenerated, so should not be checked in. It was the only one which is autogenerated, but checked in, so I removed it here.

miguelpruivo

Thank you, could you bump the changelog and also the pubspec version — I'd say that if this could potentially introduce breaking changes (specially since it plays with version constraints) to bump the minor (or major?) version.

navaronbracke · 2023-10-11T09:17:30Z

A breaking change would mean we bump the major version, per semantic versioning.

Will bump to version 6.0.0 then

miguelpruivo · 2023-10-13T16:24:28Z

A breaking change would mean we bump the major version, per semantic versioning.

Will bump to version 6.0.0 then

Correct. The question was more wether or not it could actually break or could be just some constraints that wouldn't probably break anything. But, as per your reply, major seems correct to me. Thank you!

miguelpruivo · 2023-10-18T15:19:24Z

@navaronbracke because of your recent contributions to this plugin I'd like to ask you if you're interested into become a contributor since lately I couldn't keep trace of a couple of issues that might appear (updates and related stuff) on the mobile/web side. Typically @philenius is responsible for the desktop implementations/maintenance.

Let me know if you're interested so I can assign you with the right permissions.

Thank you.

navaronbracke · 2023-10-18T16:08:04Z

@miguelpruivo Yes I would be interested in helping out. I think I'll start on the plugin_platform_interface work that I had scheduled to do, which moves the selection of the file picker implementation to the pubspec. This is the fix for #1343

After that is fixed, I'll try working my way through the backlog. I do not have a Linux machine available (nor do I have win32 or gtk experience), but I should be able to help out for other platforms.

miguelpruivo · 2023-10-19T09:39:35Z

@miguelpruivo Yes I would be interested in helping out. I think I'll start on the plugin_platform_interface work that I had scheduled to do, which moves the selection of the file picker implementation to the pubspec. This is the fix for #1343

After that is fixed, I'll try working my way through the backlog. I do not have a Linux machine available (nor do I have win32 or gtk experience), but I should be able to help out for other platforms.

Hi, thank you I really appreciate that, because due to this plugins popularity and being myself the only maintainer along with @philenius for the desktop side makes it harder to trace/handle all the PRs lately. A lot of them are just (as expected) doubts that are in wiki or stuff that is a no-op, but there are a couple of relevant issues that need attention.

I'd say to focus only in the the mobile/web issues and let alone the desktop (linux/mac/win) for @philenius and assign to him, as it is right now, unless is some immediate thing that we can take care of.

There is an action to automatically publish a new versions to the pub.dev upon master commit, so have that in mind.

I'll provide you with the right permissions now. Thank you once again.

navaronbracke added 6 commits October 8, 2023 21:55

bump Dart & Flutter version; replace deprecated lint; replace depreca…

222783a

…ted describeEnum()

bump to iOS 11.0

348a994

add CADisableMinimumFrameDurationOnPhone & UIApplicationSupportsIndir…

7ae3551

…ectInputEvents to example

remove deprecated method

727cb51

remove redundant availability checks for iOS 11

c718717

use NSURL with empty string instead of null

0b70451

navaronbracke commented Oct 8, 2023

View reviewed changes

navaronbracke commented Oct 10, 2023

View reviewed changes

remove generated podspec

847eb13

navaronbracke commented Oct 10, 2023

View reviewed changes

miguelpruivo requested changes Oct 11, 2023

View reviewed changes

bump major version & adjust changelog

3423d7b

navaronbracke requested a review from miguelpruivo October 11, 2023 09:21

miguelpruivo merged commit 411bb01 into miguelpruivo:master Oct 13, 2023

navaronbracke deleted the ios_version_bump branch October 18, 2023 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump min iOS version to 11 #1383

Bump min iOS version to 11 #1383

navaronbracke commented Oct 8, 2023

navaronbracke Oct 8, 2023 •

edited

Loading

navaronbracke Oct 8, 2023

navaronbracke Oct 8, 2023

navaronbracke Oct 8, 2023

navaronbracke Oct 8, 2023

navaronbracke Oct 10, 2023

navaronbracke Oct 10, 2023

miguelpruivo left a comment

navaronbracke commented Oct 11, 2023

miguelpruivo commented Oct 13, 2023

miguelpruivo commented Oct 18, 2023

navaronbracke commented Oct 18, 2023

miguelpruivo commented Oct 19, 2023

Bump min iOS version to 11 #1383

Bump min iOS version to 11 #1383

Conversation

navaronbracke commented Oct 8, 2023

navaronbracke Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

navaronbracke Oct 8, 2023

Choose a reason for hiding this comment

navaronbracke Oct 8, 2023

Choose a reason for hiding this comment

navaronbracke Oct 8, 2023

Choose a reason for hiding this comment

navaronbracke Oct 8, 2023

Choose a reason for hiding this comment

navaronbracke Oct 10, 2023

Choose a reason for hiding this comment

navaronbracke Oct 10, 2023

Choose a reason for hiding this comment

miguelpruivo left a comment

Choose a reason for hiding this comment

navaronbracke commented Oct 11, 2023

miguelpruivo commented Oct 13, 2023

miguelpruivo commented Oct 18, 2023

navaronbracke commented Oct 18, 2023

miguelpruivo commented Oct 19, 2023

navaronbracke Oct 8, 2023 •

edited

Loading