Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region specific settings (cacheTimeSeconds) are not applied #1

Closed
yvesf opened this issue Apr 20, 2016 · 2 comments
Closed

Region specific settings (cacheTimeSeconds) are not applied #1

yvesf opened this issue Apr 20, 2016 · 2 comments
Assignees
@mihaicostin

Comments

@yvesf
Copy link

yvesf commented Apr 20, 2016

The MemcachedCache class which represents a region doesn't read the region specific configuration.

For example, if you configure (yaml syntax):

hibernate:
    cache:
        memcached:
            operationTimeout: 700 #700ms
            # Specific per region
            com.bla.product.ClassName.cacheTimeSeconds: 300 # 5min

Then operationTimeout will be applied as intended but the cacheTimeSeconds for the "com.bla.product.ClassName" region is not applied.
@mihaicostin
Copy link
Owner

Thank you for the bug report. I'll look into it as soon as I get some time.

@mihaicostin mihaicostin self-assigned this Apr 22, 2016
mihaicostin added a commit that referenced this issue Apr 26, 2016
@mihaicostin
Fix issue #1
9c94cb5 
- Fix for https://github.com/mihaicostin/hibernate-l2-memcached/issues/ : take into account the region specific cache cacheTimeSeconds setting.
- Move all tests to java (from groovy) and add some new tests for Issue #1
@mihaicostin mihaicostin mentioned this issue Apr 26, 2016
Merged
mihaicostin added a commit that referenced this issue Apr 27, 2016
@mihaicostin
Merge pull request #2 from mihaicostin/issue_1
ec2068c 
Fix issue #1
mihaicostin added a commit that referenced this issue Apr 29, 2016
@mihaicostin
Release version 1.1.0
1ae0ce5 
Fix
- #1
@mihaicostin
Copy link
Owner

hibernate.memcached.com.bla.product.ClassName.cacheTimeSeconds = 300 will now be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaicostin mihaicostin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yvesf @mihaicostin