Allow subclassing of RegExps #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| // 2. RegExp.make('gi')`....` to specify flags | ||
| // 3. RegExp.make.bind(RegExpSubClass)`...` with a this value that specifies | ||
| // a different constructor. | ||
| const xType = typeof x; |
There was a problem hiding this comment.
Just use typeof x twice. Should be shorter and easier to read; also engines optimise this better when typeof is a direct operand of ==/===.
|
@bergus, are you ok with patch as it stands? |
| @@ -306,7 +306,7 @@ RegExp.make = (function () { | |||
| * a start context, and RegExp source, and returns an end context. | |||
| */ | |||
| function parseRegExpSource(eventHandler) { | |||
| const { | |||
| var { | |||
There was a problem hiding this comment.
why is this changed to var?
There was a problem hiding this comment.
still not sure why this is changed to var
There was a problem hiding this comment.
This is the same limitation of closure compiler. It types consts in a separate pass from vars.
mikesamuel
added a commit
that referenced
this pull request
Oct 24, 2015
Allow subclassing of RegExps
| @@ -1065,12 +1076,25 @@ RegExp.make = (function () { | |||
| pattern += rawLiteralPart; | |||
| addTemplateGroups(i+1); | |||
| } | |||
| const output = new RegExp(pattern, flags); | |||
| var output = new ctor(pattern, flags); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.