Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DRF 3.0 #23

Closed
gabriel-amram opened this issue Dec 3, 2014 · 4 comments · Fixed by #29
Closed

Support for DRF 3.0 #23

gabriel-amram opened this issue Dec 3, 2014 · 4 comments · Fixed by #29

Comments

@gabriel-amram
Copy link

Hello,
DRF has introduced some significant changes in some of the logic regarding the Serializer.
For example, there is no more pre_save, but perform_create and perform_update instead that this package relies upon.
Another thing is request.DATA that is being deprecated and serializer.object that became serializer.validated_data.

Is there a workkaround for the time being so that we could still use DRF 3.0 with DRF-bulk?

Thanks!

@miki725
Copy link
Owner

miki725 commented Dec 3, 2014

Not yet. Ill be upgrading the library soon to support DRF3.
On Dec 3, 2014 8:37 AM, "Gabriel Amram" [email protected] wrote:

Hello,
DRF has introduced some significant changes in some of the logic regarding
the Serializer.
For example, there is no more pre_save, but perform_create and
perform_update instead that this package relies upon.
Another thing is request.DATA that is being deprecated and
serializer.object that became serializer.validated_data.

Is there a workkaround for the time being so that we could still use DRF
3.0 with DRF-bulk?

Thanks!


Reply to this email directly or view it on GitHub
#23.

@merll
Copy link

merll commented Dec 9, 2014

Please have a look at PR #24 and see if it works for you.

@kevin-brown
Copy link
Contributor

I just wrote a huge answer on Stack Overflow about doing this for the general case, as it has come up quite a few times since 3.0 was released.

http://stackoverflow.com/a/27871396/359284

It may be useful to those looking to implement it for this package. I do believe it is possible to make it compatible for both DRF 2 and 3, it might make you cry though. Since the current PR is open, I'll take a look at it this weekend to see if there are any easy fixes that can be made.

@miki725
Copy link
Owner

miki725 commented Jan 11, 2015

@kevin-brown thank you. Ive been so busy for the last couple of weeks and didnt had a chance yet to look into this. I would love to see DRF2 and DRF3 support however if there is no "straight-forward" way of doing that without doing crazy things, I would rather have 2 branches going, one for each DRF version and keep releasing them both.

@miki725 miki725 mentioned this issue Feb 2, 2015
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants