Specify __all__ in mixins and generics #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-brown
changed the title
__all__ in mixins and generics
|
Can you add your name to readme (I just changed to use my github link instead of email if you want to follow the same format - 701734a) and then Ill merge this. |
Closed
This fixes #2 by specifically saying what will be imported from `mixins.py` and `generics.py` when a star import is done on these files. This is done within `__init__.py`, so the classes can be imported directly from there. This prevents an issue where `rest_framework.mixins` was being imported from `generics.py`, so users were not able to import `rest_bulk_create.mixins`.
|
thanx. just merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2 by specifically saying what will be imported from
mixins.pyandgenerics.pywhen a star import is done on these files. This is done within__init__.py, so the classes can be imported directly from there. This prevents an issue whererest_framework.mixinswas being imported fromgenerics.py, so users were not able to importrest_bulk_create.mixins.