-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Use version instead of timestamp when generate go structs #26
Comments
One solution you can use directly is to use the
We added that not too long ago exactly because we needed reproducibility (e.g. in CI). Does that work for you? |
Seems great! Still recommend add a version if possible in later releases. An example is what protoc does
-B works for me now. Thanks! |
@miku Do you mind me submitting a PR to add version in the banner? |
Since v0.1.23 comments will contain the version of the tool that generated the struct. Thanks for highlighting the issue. |
Good to know, thanks! |
A comment like "// Root was generated 2019-06-11 16:27:04 by tir on hayiti." is added to the code when generate go structs from xml. However, in a batch-like operation (iterate xml files in a directory), even 1 xml file changes, we will see update in every file, which is not friendly to a git commit. Compared to timestamp, sometimes version is more useful as features are always binded to a specific version. It will be nice if a feature switch is provided to let users choose which comments they prefer.
The text was updated successfully, but these errors were encountered: