Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStruct causes NameError in Rake13.2.0 #1109

Closed
rhiroe opened this issue Apr 10, 2024 · 0 comments · Fixed by #1110
Closed

OpenStruct causes NameError in Rake13.2.0 #1109

rhiroe opened this issue Apr 10, 2024 · 0 comments · Fixed by #1110

Comments

@rhiroe
Copy link
Contributor

rhiroe commented Apr 10, 2024 •
edited
Loading

wicked_pdf/lib/wicked_pdf.rb

Line 34 in 345b12b

config = OpenStruct.new(@@config)

I bump the version of Rake to 13.2.0 and got a NameError at the above point.

Rake uses Struct instead of OpenStruct in version 13.2.0.
ruby/rake#545

It seems that OpenStruct loading is implicitly dependent on Rake.

I suggest adding require 'ostruct' or using Struct instead of the deprecated OpenStruct.
rhiroe added a commit to rhiroe/wicked_pdf that referenced this issue Apr 18, 2024
@rhiroe
fix: add require 'ostruct'
69f9dfc 
resolved mileszs#1109
Since the loading of ostract was dependent on Rake, explicitly load it and resolve the dependency.
Because Rake does not load ostract after version 13.2.0.
rhiroe added a commit to rhiroe/wicked_pdf that referenced this issue Apr 18, 2024
@rhiroe
fix: OpenStruct causes NameError in Rake13.2.0
9d95051 
resolved mileszs#1109
@rhiroe rhiroe mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: OpenStruct causes NameError in Rake13.2.0 rhiroe/wicked_pdf
1 participant
@rhiroe