Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to build with rust 1.80 #3795

Closed
wants to merge 3 commits into from

Conversation

chenrui333
Copy link

seeing some time related failure

error[E0282]: type annotations needed for `Box<_>`
  --> /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

has been addressed with 0.3.36, time-rs/time#693

Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@martinthonon
Copy link

Maybe you should add time to dependencies in Cargo.toml instead of reformatting some lines.

[dependencies]
blake2-rfc = "0.2"
chrono = "0.4.11"
clap = { version = "2.33", features = ["yaml"] }
ctrlc = { version = "3.1", features = ["termination"] }
cursive_table_view = "0.14.0"
humansize = "1.1.0"
serde = "1"
futures = "0.3.19"
serde_json = "1"
log = "0.4"
term = "0.6"
time = "0.3.36"

@yeastplume
Copy link
Member

Thanks for pointing this out, it's actually cursive that includes the broken dependency and needs to be updated, so I'm just doing that in another PR.

@chenrui333
Copy link
Author

any interest of merging this PR?

@yeastplume
Copy link
Member

@chenrui333 Thanks for pointing this out, it's covered in #3796 and I'll be doing a new release soon

@yeastplume yeastplume closed this Sep 12, 2024
@chenrui333 chenrui333 deleted the rust-1.80 branch September 18, 2024 18:30
@chenrui333
Copy link
Author

Thanks @yeastplume!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants