Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trainlines: Follow tracks #231

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Trainlines: Follow tracks #231

merged 2 commits into from
Jan 21, 2022

Conversation

PeterNerlich
Copy link
Contributor

This pull request adds support for the rail_pos and linepath_from_prv metadata attributes on map objects to display them, if present.

Associated PR in mapserver_mod

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1709461249

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.461%
Totals Coverage Status
Change from base Build 1707072551: 0.0%
Covered Lines: 1300
Relevant Lines: 1845
💛 - Coveralls

@BuckarooBanzay
Copy link
Member

i don't really have time to test this myself, i'm assuming you did test this thoroughly, right? 😉

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jan 20, 2022
@PeterNerlich
Copy link
Contributor Author

PeterNerlich commented Jan 20, 2022 •
edited
Loading

As thoroughly as spending a couple of hours with it goes. I started completely unfamiliar with go, but I'm very confident in my changes here regarding that language. xD
Regarding the JS not much should be able to go wrong, and I feel very comfortable in that language. Worst thing that could happen should be the code breaking and the trainline layer not showing anything, I think. Otherwise there should be not much going on. It's backwards compatible as well.

@BuckarooBanzay BuckarooBanzay merged commit e43f883 into minetest-mapserver:master Jan 21, 2022
@PeterNerlich PeterNerlich deleted the follow_tracks branch January 28, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterNerlich @coveralls @BuckarooBanzay