Add support for player skins via SkinsDB #284
Conversation
Pull Request Test Coverage Report for Build 3710908515
💛 - Coveralls |
| Default colors, see: [colors.txt](../server/static/colors.txt) | ||
| Default colors, see: [colors directory](../public/colors) |
There was a problem hiding this comment.
I think this refers to an old implementation, so I just updated this to the directory where colours are stored.
| const marker = L.marker([player.pos.z, player.pos.x], {icon: this.getIcon(player)}); | ||
|
|
||
| marker.bindPopup(this.createPopup(player)); | ||
| marker.bindPopup(this.createPopup(player), {minWidth: 220}); |
There was a problem hiding this comment.
I made the popup wider by default just because it looked a bit squashed with the player portrait included.
|
|
||
| // no cached skin, we need to build the image | ||
| let img = new Image(); | ||
| img.onload = function() { |
There was a problem hiding this comment.
The skins will load asyncronously, and then be added to the playerSkins map/cache, so after a subsequent update they'll rerender.
| @@ -69,7 +69,6 @@ See: [Incremental rendering](doc/incrementalrendering.md) | |||
| ## Planned Features | |||
|
|
|||
| * Isometric view | |||
| * Skin support | |||
There was a problem hiding this comment.
If there are other skin mods or methods of support still required, I can add this back.
|
wow, this looks awesome 😲 🎉 |
Adds support for SkinsDB, allowing display of custom player skins on the map.
The implementation will serve skin textures directly from the
skinsdb/texturesdirectory, and assemble previews on the client. I believe this should support older (32x64) and newer texture (64x64) skin formats. Overlays are not supported (yet?!).Also updated the popup when selecting a player, to show a preview of the player with their skin. Also added a small crown icon next to the name of players flagged as moderators in this popup.