Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent POI image from vertically overflowing too much #395

Conversation

Emojigit
Copy link
Contributor

This PR fixes an issue in #389. Previously, POI owners could set a tall image that overflows the screen. The modified code limits the height to 75% of the viewpoint height and allows scrolling down to see the remaining parts.

This PR is ready for review.

圖片

@coveralls
Copy link

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9720012796

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 27.84%

Totals Coverage Status
Change from base Build 9715232799: 0.0%
Covered Lines: 968
Relevant Lines: 3477

💛 - Coveralls

@BuckarooBanzay BuckarooBanzay merged commit 02bb99f into minetest-mapserver:master Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants