Add option to set NewerNoncurrentVersions to Lifecycle #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Dec 10, 2024
| def __init__(self, noncurrent_days: int | None = None): | ||
| def __init__(self, | ||
| noncurrent_days: int | None = None, | ||
| noncurrent_versions: int | None = None): |
There was a problem hiding this comment.
- Rename
noncurrent_versionsasnewer_noncurrent_versionseverywhere - Add validation here like
if noncurrent_days is None and newer_noncurrent_versions is None:
raise ValueError("either noncurrent_days or newer_noncurrent_versions must be set")
Comment on lines
+200
to
+206
|
|
||
| if not self._noncurrent_days and not self._noncurrent_versions: | ||
| raise ValueError("Either one value must be set") | ||
|
|
||
| if self._noncurrent_versions and self._noncurrent_days: | ||
| raise ValueError("Only one value can be set") | ||
|
|
Comment on lines
+208
to
+210
| SubElement(element, "NoncurrentDays", | ||
| str(self._noncurrent_days)) | ||
|
|
There was a problem hiding this comment.
Suggested change
| SubElement(element, "NoncurrentDays", | |
| str(self._noncurrent_days)) | |
| SubElement(element, "NoncurrentDays", str(self._noncurrent_days)) |
| if self._noncurrent_versions: | ||
| SubElement(element, "NewerNoncurrentVersions", | ||
| str(self._noncurrent_versions)) | ||
|
|
||
| return element | ||
|
|
There was a problem hiding this comment.
Add newer_noncurrent_versions to class NoncurrentVersionTransition too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed this functionality for myself and couldn't find it in your repo, so I added it.
lifecyceconfig.NoncurrentVersionExpirationonly allows either_noncurrent_daysor_noncurrent_versionsto be set, but not both at the same time. I don't know minIO well enough to know whether it would be possible to set both at the same time. Feel free to make changes.