Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xpath with siteprism #2454

Open
colinbruce opened this issue Aug 1, 2018 · 0 comments
Open

Replace xpath with siteprism #2454

colinbruce opened this issue Aug 1, 2018 · 0 comments

Comments

@colinbruce
Copy link
Contributor

As part of #2453 xpath was used to simulate a hover and click in the advocate claim steps

This allowed both poltergeist and chrome-webdriver to locate and click the required button.

If this behaviour can be replicated in SitePrism, this change should be backed out and restored to pure SitePrism behaviour
@colinbruce colinbruce mentioned this issue Aug 1, 2018
Merged
1 task
colinbruce added a commit that referenced this issue Aug 1, 2018
@colinbruce
Working features in browser (#2453)
534361b 
* Replace `.trigger.click` with `.click`
* Set an absolute path for uploading files
* Check `A copy of the indictment` to prevent pop up appearing
* Switch Scheme10 offence to xpath match
The button is only shown when hovering, this solution works in poltergeist headless _and_ chrome webdriver, but should be replaced with SitePrism references long term, see #2454 
* Add timeout for user login
slow rendering after a logout was causing a flickering test when
run in browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinbruce