Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cucumber-rails from 2.0.0 to 2.1.0 #3417

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 1, 2020

Bumps cucumber-rails from 2.0.0 to 2.1.0.

Release notes

Sourced from cucumber-rails's releases.

v2.1.0

New Features

  • New Metadata has been added to allow user to search rubygems better
  • Allow cucumber 4 to be used

Changed

  • Ruby 2.3 usage has now been removed from gem
  • Database cleaner now won't throw warnings when using v1.8+ (Older versions unsupported)
  • A bunch of ruby / rubocop tidy ups
Changelog

Sourced from cucumber-rails's changelog.

v2.1.0 (2020-06-15)

New Features

  • Added metadata to allow gem to be searched / indexed by rubygems (#447 [orien])

  • Allow Cucumber 4 to be used as an option for cucumber-rails

    • NB: Cucumber4 changes quite a lot of logic with auto-loaders. This means that any previous logic that relied implicitly on load-order "may" be affected (#453 [luke-hill] / [deivid-rodriguez])

Changed

  • Dropped Ruby 2.3 support (target 2.4 - 2.7) (#466 [mvz])

  • Refactored suite to remove a lot of old Rails3/4.0 "ism's"

    • Also migrated a lot of old cucumber styles to cucumber4 (#441 [luke-hill])
  • Refactored alias logic for overriding Rails methods to use Module#prepend (#457 [wagenet])

  • database_cleaner (when used), at a version >= 1.8 will now silence all warnings

    • The suite internally will only test a version >= 1.8, so other versions will work but are un-maintained (#463 [deivid-rodriguez])

Fixed

  • Various rubocop / rspec styling fixes (#445 / #449 / #450 / #451 / #452 / #465 [mvz] / [luke-hill])

  • Various CI fixes (#444 / #460 / #464 [mvz] / [damonjmurray] / [deivid-rodriguez])

  • Avoid printing a warning about config.cache_classes being set to false when Spring is used (#462 [janko])

Commits
  • 1f89a25 Merge pull request #466 from mvz/drop-support-for-ruby-2-3
  • 54a0ef9 Enable new cops
  • fc9fdac Update aruba to 1.0
  • fe8e23a Autocorrect Performance/RegexpMatch offenses
  • 059343a Update rubocop and related dependencies
  • b3008ae Add Ruby 2.7 to the matrix
  • 3df265d Target Ruby 2.4+
  • 44b8b52 Merge pull request #465 from mvz/update-rubocop
  • 0a6a5a3 Update rubocop and friends
  • 050b01f Merge pull request #453 from cucumber/feature/enable_cucumber_4
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 1, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/cucumber-rails-2.1.0 branch from 1f84095 to ee4d66e Compare July 16, 2020 08:57
@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

@dependabot-preview
Copy link
Contributor Author

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@naseberry naseberry force-pushed the dependabot/bundler/cucumber-rails-2.1.0 branch from ee4d66e to fcdf25e Compare September 2, 2020 09:28
@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@naseberry
Copy link
Contributor

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/cucumber-rails-2.1.0 branch from fcdf25e to d7f10c8 Compare September 2, 2020 11:26
@naseberry
Copy link
Contributor

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/cucumber-rails-2.1.0 branch from d7f10c8 to 4933caf Compare September 24, 2020 11:49
@naseberry naseberry force-pushed the dependabot/bundler/cucumber-rails-2.1.0 branch from 4933caf to 1a7308f Compare September 29, 2020 15:19
@naseberry
Copy link
Contributor

@dependabot ignore this minor version

This is causing our feature tests to fail 😢

I don't think it can be easily resolved at the moment - the errors we're getting are the same as those documented in open issue cucumber/cucumber-ruby#1445.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/cucumber-rails-2.1.0 branch September 30, 2020 09:06
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you about version 2.1.x again, unless you re-open this PR or update to a 2.1.x release yourself.

@jsugarman
Copy link
Contributor

@dependabot ignore this minor version

This is causing our feature tests to fail 😢

I don't think it can be easily resolved at the moment - the errors we're getting are the same as those documented in open issue cucumber/cucumber-ruby#1445.

ironically i have been having trouble with junit formatter for split-by-timings as well, so have switched out to the json formatter instead - which does appear to be working. So could rebase once json formatter is in master to see if that fixes the failing specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants