Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS-1678 AP day summary view #2293

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

bobmeredith
Copy link
Contributor

@bobmeredith bobmeredith commented Jan 15, 2025

Context

https://dsdmoj.atlassian.net/browse/APS-1678

Changes in this PR

This PR adds the AP occupancy view page in a moderately basic form. The page loads the premisesDaySummary and shows the high-level information in a summary table. It also calculates any characteristic overbooking and shows a summary of this in the blue banner - only if there is a characteristic overbooking. The design doesn't appear to cover what to do in the event of a non-characteristic overbooking.

There are also a couple of navigation arrows to go to the next and previous days (the dates for which are sent by the API).

Since this functionality does not use the lists of bookings or lost beds (apart from counting the lost bed records for the summary) I've not yet added these lists in the factory for the day summary. That will come in the next ticket.

Screenshots of UI changes

image

@bobmeredith bobmeredith force-pushed the feature/APS-1678_AP_occupancy_day_view branch from e3c2bf4 to 74ad06c Compare January 16, 2025 17:35
@bobmeredith bobmeredith marked this pull request as ready for review January 16, 2025 17:39
@bobmeredith bobmeredith force-pushed the feature/APS-1678_AP_occupancy_day_view branch from c3d363c to e16c5ed Compare January 20, 2025 08:33
Copy link
Contributor

@froddd froddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good -- couple of suggestions around error checking and pre-emptively adding test and implementation for strict overbooking summary text.

server/utils/premises/occupancy.test.ts Show resolved Hide resolved
server/utils/premises/occupancy.ts Outdated Show resolved Hide resolved
@bobmeredith bobmeredith force-pushed the feature/APS-1678_AP_occupancy_day_view branch from b5ff2fe to 838d369 Compare January 21, 2025 13:24
@bobmeredith bobmeredith force-pushed the feature/APS-1678_AP_occupancy_day_view branch from 838d369 to a3cb31d Compare January 21, 2025 13:59
@bobmeredith bobmeredith merged commit a345cd4 into main Jan 21, 2025
7 checks passed
@bobmeredith bobmeredith deleted the feature/APS-1678_AP_occupancy_day_view branch January 21, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants