Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2748 - Check egress via network firewall #1678

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Dec 10, 2024

Purpose

Ensure that requests not permitted by the allow list are dropped

Fixes MLPAB-2748 MLPAB-2775

Approach

  • write a script to make a request for an address not on the allow list
  • build an egress checker image
  • deploy lambda function to check egress if enabled

Learning

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (2879dc9) to head (c25239c).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         285      285           
  Lines       16145    16145           
=======================================
  Hits        15334    15334           
  Misses        641      641           
  Partials      170      170           
Flag Coverage Δ
unittests 94.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review December 31, 2024 16:07
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner December 31, 2024 16:07
hawx
hawx previously approved these changes Jan 2, 2025
@andrewpearce-digital andrewpearce-digital merged commit f9b12b0 into main Jan 2, 2025
32 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2748-check-requests-for-addresses-not-on-the-allow-list-are-dropped branch January 2, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants