Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Jest with changes from template project #382

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

tpmcgowan
Copy link
Contributor

  • Bring over recent changes from the template project to speed up Jest.
  • Remove custom test runner, jest-jasmine2 - which looks to have been added early in the project to work around a bug but is no longer needed.
  • Tweak a few tests to prevent warnings about open handles being left on test runs

Performance improvements (running locally):

Before

Test Suites: 109 passed, 109 total
Tests:       598 passed, 598 total
Snapshots:   0 total
Time:        28.109 s, estimated 35 s

After

Test Suites: 109 passed, 109 total
Tests:       598 passed, 598 total
Snapshots:   0 total
Time:        7.582 s, estimated 14 s

Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpmcgowan tpmcgowan merged commit c134d80 into main Jan 5, 2023
@tpmcgowan tpmcgowan deleted the speed-up-jest branch January 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants